refactor(riscv): split vector semantics out of cpu.rs - #202
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
Conversation
cpu.rs exceeded the AGENTS.md hard split triggers (2000 lines / 150 kB). Move the vector (RVV) element access and data-path execution group, including set_vtype, into cpu/vector.rs with no behavior change.
This was referenced Aug 11, 2026
Member
|
Thanks @carlosqwqqwq for doing the module-split work and for keeping the follow-on fixes organized around it. We are consolidating the relevant structure into #203 instead: the rollup centralizes RVV validation in its own module and extracts the touched mixed-width conversion semantics into a focused sibling, alongside the direct/SMIR/JIT/QEMU coverage that depends on those boundaries. We will not take the broader mechanical split as a separate PR, so I am closing #202 as superseded by #203. Your semantic contributions carried into the rollup are credited on the corresponding commits. |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/isa/riscv/cpu.rscurrently exceeds the hard split triggers inAGENTS.md(2000 lines / 150 kB). This change moves the vector (RVV) element access and data-path execution group —sew_bytesthroughset_vtype, includingexec_vector— into a newsrc/isa/riscv/cpu/vector.rssubmodule. No behavior changes: the same methods, in the same order, withexec_vectorandset_vtypere-exported aspub(super)for thecpumodule.Validation
cargo build --locked --release --no-default-features --features smir-jitpasses.cargo test --libpasses: 8212 passed; 0 failed; 2 ignored.