fix(riscv): reject vid.v with non-zero vs2 - #214
Closed
carlosqwqqwq wants to merge 2 commits into
Closed
Conversation
cpu.rs exceeded the AGENTS.md hard split triggers (2000 lines / 150 kB). Move the vector (RVV) element access and data-path execution group, including set_vtype, into cpu/vector.rs with no behavior change.
Member
|
Thanks @carlosqwqqwq. The reserved nonzero |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): reject vid.v with non-zero vs2
Closes #213
Summary
vid.vis a VMUNARY0 instruction whosevs2field is reserved and must bev0(RVV §11.14); any othervs2is a reserved encoding. RAX ignored the field and executed the instruction.Validation
vs2values (16 and 3, including the masked form) and the legalvs2 = v0control.cargo test --lib: cpu suite 70 passed, 0 failed.Notes
The vector semantics live in
cpu/vector.rsafter the refactor in #202, so this change does not grow the oversizedcpu.rs.