Support Embodiment Placement for Droid/Franka - #954
Merged
Conversation
qianl-nv
commented
Jul 27, 2026
zhx06
force-pushed
the
zxiao/feature/robo_placement_prototype
branch
from
July 27, 2026 15:54
aa6d4e5 to
1504896
Compare
qianl-nv
force-pushed
the
qianl/feature/cache-stand-height-usd
branch
2 times, most recently
from
July 27, 2026 16:26
dd9da4a to
b7bc268
Compare
qianl-nv
commented
Jul 27, 2026
qianl-nv
force-pushed
the
qianl/feature/cache-stand-height-usd
branch
from
July 27, 2026 16:39
b7bc268 to
828da7a
Compare
qianl-nv
changed the base branch from
zxiao/feature/robo_placement_prototype
to
main
July 27, 2026 16:40
qianl-nv
marked this pull request as ready for review
July 27, 2026 16:40
qianl-nv
requested review from
alexmillane,
cvolkcvolk,
peterd-NV,
viiik-inside,
xyao-nv and
zhx06
as code owners
July 27, 2026 16:40
Contributor
Greptile SummaryThis PR locally composes Franka and Droid robot-and-stand USD assemblies.
Confidence Score: 3/5The PR should not merge until composed USD cache paths uniquely represent the requested stand height. Distinct supported stand-height values can resolve to one rounded filename, allowing a later embodiment construction to overwrite the USD referenced by an earlier configuration and produce order-dependent stand geometry. Files Needing Attention: isaaclab_arena/embodiments/robot_on_stand_utils.py Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Embodiment configuration] --> B[compose_on_stand_usd]
B --> C[Resolve robot and stand USDs]
C --> D[Mount stand beneath panda_link0]
D --> E[Write composed USD to local cache]
E --> F[ArticulationCfg spawn path]
F --> G[Root-pose reset moves robot, stand, and cameras]
Reviews (1): Last reviewed commit: "Add shared on-stand USD compose for Droi..." | Re-trigger Greptile |
zhx06
reviewed
Jul 27, 2026
zhx06
reviewed
Jul 27, 2026
zhx06
reviewed
Jul 27, 2026
xyao-nv
reviewed
Jul 28, 2026
xyao-nv
reviewed
Jul 28, 2026
xyao-nv
reviewed
Jul 28, 2026
xyao-nv
approved these changes
Jul 28, 2026
xyao-nv
reviewed
Jul 28, 2026
qianl-nv
commented
Jul 28, 2026
qianl-nv
left a comment
Collaborator
Author
There was a problem hiding this comment.
Addressed all review comments
Compose robot+stand locally under panda_link0 so relation placement moves the full assembly via write_root_pose_to_sim. Droid keeps configurable stand_height_m; Franka uses the fixed legacy stand height. Signed-off-by: Qian Lin <qianl@nvidia.com>
Explain how initial_pose and stand_height_m interact when placing the robot on the floor. Signed-off-by: Qian Lin <qianl@nvidia.com>
Move robot USD/paths and default stand height into embodiment-specific specs so compose helpers stay generic and Franka cfg copies stay at call sites. Signed-off-by: Qian Lin <qianl@nvidia.com>
Catch Sdf.Layer.Save() returning False so a failed write does not get os.replace'd into the cache. Signed-off-by: Qian Lin <qianl@nvidia.com>
Drop the Franka stand-under-link0 sim test covered by Droid runtime checks, and rely on run_simulation_app_function headless defaults. Signed-off-by: Qian Lin <qianl@nvidia.com>
qianl-nv
force-pushed
the
qianl/feature/cache-stand-height-usd
branch
from
July 28, 2026 03:12
828da7a to
c1d726d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local on-stand USD compose for Franka and Droid to support placement with stand/camera
Detailed description
panda_link0lets a singlewrite_root_pose_to_simmove the full assembly in Fabric/Kit.robot_on_stand_utils, embodiment-specific mount helpers) instead of relying on Nucleus combined assets or a separate Droid stand scene entity.test_robot_on_stand_utils.pyand mergetest_droid_stand_height.pyinto it.Before:

After:
