fix(riscv): reject reserved RV32 shift-immediate encodings - #254
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
fix(riscv): reject reserved RV32 shift-immediate encodings#254carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Member
|
Thank you for reporting #249 and proposing a fix. This is now independently consolidated in #255 for the base and Zb* RV32 shift-immediate families, with RV64 controls, SMIR/JIT frontier checks, and an independent qemu-riscv32 SIGILL probe for the reported witness. To keep review and CI focused on one rollup, I am closing this PR in favor of #255. You are credited as co-author on the rollup commit. |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): reject reserved RV32 shift-immediate encodings
Closes #249
Summary
On RV32, the shift-immediate instructions
slli/srli/sraiencode a 5-bitshamtin bits 24:20; bit 25 is part offunct6and must be 0. The Zb* overlays (bseti/bclri/binvi/bexti/rori) share the same field and are likewise reserved with bit25 set on RV32. The affected RV32 decoder maskedshamtto 5 bits but never rejected a set bit25, so encodings such assrli x5,x6,32(0x02035293) executed as a shift by zero instead of raising an illegal-instruction trap. QEMU raises SIGILL for these encodings.The fix rejects any RV32 OP-IMM shift-family encoding with bit25 set in both
decode_shift_left_immanddecode_shift_right_imm.Validation
cargo test --lib: the targeted shift-immediate tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.