fix(riscv): reject reserved vm=0 encodings of vmv.x.s/vfmv.f.s - #250
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
fix(riscv): reject reserved vm=0 encodings of vmv.x.s/vfmv.f.s#250carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Member
|
Thank you for reporting #245 and proposing a fix. This is now independently consolidated in #255, which covers the masked encodings for all four integer/FP scalar-move directions and validates the direct, SMIR/JIT, and QEMU paths. To keep review and CI focused on one rollup, I am closing this PR in favor of #255. You are credited as co-author on the rollup commit. |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): reject reserved vm=0 encodings of vmv.x.s/vfmv.f.s
Closes #245
Summary
The RISC-V V extension reserves the masked (
vm=0) encodings ofvmv.x.sandvfmv.f.s(RVV 16.2/16.3): these whole-register moves never use the mask register, so the vm bit must be 1. The affectedVmvXS/VfmvFSbranches executed unconditionally and ignored the vm bit, so reserved encodings such asvmv.x.s a1, v2with vm=0 were executed and wrote the scalar register. QEMU raises SIGILL for the same encodings.The fix rejects
vm == 0at the entry of both branches.Validation
cargo test --lib: the targeted vmv.x.s/vfmv.f.s tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.