Skip to content

feat: support session connect attrs in /slow_query#1900

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
yibin87:feature/issue-1899-slow-query-session-attrs
Jun 10, 2026
Merged

feat: support session connect attrs in /slow_query#1900
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
yibin87:feature/issue-1899-slow-query-session-attrs

Conversation

@yibin87

@yibin87 yibin87 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Issue

Issue Number: close #1899

Summary

  • expose session connect attrs as an optional column on the /slow_query list page and keep it unchecked by default
  • add a Session Attributes tab on the slow query detail page and render the value as JSON when the schema provides the field
  • keep backward compatibility by only surfacing the field when it exists in the slow query schema, while preserving the existing warnings tab fallback for older TiDB versions
  • extend the mock slow query schema, fixtures, and integration assertions to cover Session_connect_attrs end to end

Testing

  • git diff --check
  • go test ./pkg/apiserver/slowquery -count=1
  • pnpm -C ui build:lib
img_v3_0212h_8ad7d7b6-1948-4145-a4ac-c203920820ag img_v3_0212h_f735b180-8045-46fb-a8da-88583c29e2dg img_v3_0212h_d434e67a-f994-4018-b745-8499eee36f6g

Signed-off-by: yibin87 <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot Bot requested a review from Renkai June 10, 2026 05:16
@ti-chi-bot ti-chi-bot Bot added the size/L label Jun 10, 2026
@ti-chi-bot ti-chi-bot Bot added the lgtm label Jun 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot

ti-chi-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-06-10 05:53:35.426561465 +0000 UTC m=+939316.496878856: ☑️ agreed by shhdgit.

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 10, 2026
@ti-chi-bot ti-chi-bot Bot merged commit f01fc25 into pingcap:master Jun 10, 2026
10 of 14 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #1901.
But this PR has conflicts, please resolve them!

yibin87 added a commit to ti-chi-bot/tidb-dashboard that referenced this pull request Jun 11, 2026
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
yibin87 added a commit to ti-chi-bot/tidb-dashboard that referenced this pull request Jun 11, 2026
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
yibin87 added a commit that referenced this pull request Jun 11, 2026
* This is an automated cherry-pick of #1900

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix: align slow query session attrs cherry-pick

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: yibin <huyibin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support session connect attrs in /slow_query

3 participants