Skip to content

fix: sync generated slow query client artifacts after #1900#1906

Open
yibin87 wants to merge 1 commit into
masterfrom
fix-pr1900-generated-artifacts
Open

fix: sync generated slow query client artifacts after #1900#1906
yibin87 wants to merge 1 commit into
masterfrom
fix-pr1900-generated-artifacts

Conversation

@yibin87

@yibin87 yibin87 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #1900.

Summary:
PR #1900 added the session_connect_attrs field to the backend slow query model, but the generated frontend client artifacts were not synced.

This PR updates the generated files that should reflect that field:

  • ui/packages/tidb-dashboard-client/swagger/spec.json
  • ui/packages/tidb-dashboard-client/src/client/api/models/slowquery-model.ts
  • ui/packages/tidb-dashboard-lib/src/client/models.ts

Validation:

  • Re-ran scripts/generate_swagger_spec.sh and confirmed ui/packages/tidb-dashboard-client/swagger/spec.json was stale and needed session_connect_attrs.
  • Full frontend OpenAPI regeneration could not be executed in this environment because openapi-generator-cli requires a local Java runtime, which is not installed here.
  • Synced the affected generated TS model outputs to match the regenerated spec.

Signed-off-by: yibin87 <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot Bot requested review from Renkai and zimulala June 12, 2026 04:45
@ti-chi-bot

ti-chi-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign baurine for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/S label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant