Skip to content

feat: support session connect attrs in /slow_query (#1900)#1901

Merged
yibin87 merged 2 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-1900-to-release-8.5
Jun 11, 2026
Merged

feat: support session connect attrs in /slow_query (#1900)#1901
yibin87 merged 2 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-1900-to-release-8.5

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #1900

Issue

Issue Number: close #1899

Summary

  • expose session connect attrs as an optional column on the /slow_query list page and keep it unchecked by default
  • add a Session Attributes tab on the slow query detail page and render the value as JSON when the schema provides the field
  • keep backward compatibility by only surfacing the field when it exists in the slow query schema, while preserving the existing warnings tab fallback for older TiDB versions
  • extend the mock slow query schema, fixtures, and integration assertions to cover Session_connect_attrs end to end

Testing

  • git diff --check
  • go test ./pkg/apiserver/slowquery -count=1
  • pnpm -C ui build:lib
img_v3_0212h_8ad7d7b6-1948-4145-a4ac-c203920820ag img_v3_0212h_f735b180-8045-46fb-a8da-88583c29e2dg img_v3_0212h_d434e67a-f994-4018-b745-8499eee36f6g

@ti-chi-bot

Copy link
Copy Markdown
Member Author

@yibin87 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot Bot added the lgtm label Jun 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 11, 2026
@yibin87

yibin87 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

/hold

@yibin87 yibin87 force-pushed the cherry-pick-1900-to-release-8.5 branch from 7784b39 to b227919 Compare June 11, 2026 01:03
@ti-chi-bot ti-chi-bot Bot removed the lgtm label Jun 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-06-11 00:57:08.753077083 +0000 UTC m=+1007929.823394463: ☑️ agreed by shhdgit.
  • 2026-06-11 01:03:34.575138535 +0000 UTC m=+1008315.645455924: ✖️🔁 reset by yibin87.

@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@yibin87 yibin87 force-pushed the cherry-pick-1900-to-release-8.5 branch from b227919 to a67d4e7 Compare June 11, 2026 01:27
@yibin87 yibin87 merged commit ef5568c into pingcap:release-8.5 Jun 11, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants