Skip to content

chore(devex): stop instructing agents to run hogli review - #90039

Merged
trunk-io[bot] merged 1 commit into
masterfrom
posthog/stop-triggering-hogli-review
Aug 27, 2026
Merged

chore(devex): stop instructing agents to run hogli review#90039
trunk-io[bot] merged 1 commit into
masterfrom
posthog/stop-triggering-hogli-review

Conversation

@gantoine

Copy link
Copy Markdown
Member

Problem

hogli review needs a per-person seat on PostHog's Greptile workspace, and seats are granted by hand right now (SSO is an enterprise feature we don't have). AGENTS.md told every agent to run it before opening a PR, so anyone without a seat gets walked through a sign-up flow that creates their own personal Greptile workspace rather than joining PostHog's — which is what happened to the first person who hit it.

Changes

  • Agents no longer run hogli review when told to open a PR. The Greptile bot reviews PRs as it did before this wiring landed.
  • The reviewing-before-pr skill stays, but is now opt-in: it fires only when someone asks for a local Greptile review by name, and says up front that a seat is needed.
  • hogli ci:preflight no longer nudges toward hogli review on code diffs.
  • Mechanical: removed the always-invoke entry and section from AGENTS.md, the PR-template bullet, and the preflight check's test assertions.

The hogli review command, the flox install of the Greptile CLI, and the .greptile/ config are untouched — people with a seat can still run it.

How did you test this code?

  • uv run pytest tools/hogli-commands/hogli_commands/tests/test_ci_preflight.py — 32 passed. The nudge test now covers mypy only.
  • ruff check and ruff format --check clean on both changed Python files.
  • Not checked: that a fresh agent session no longer reaches for the review. That is a prompt-level change, visible by reading the diff.

Automatic notifications

  • Publish to changelog?

Docs update

None — all surfaces here are agent guidance in AGENTS.md and .agents/skills/.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

  • Written by the PostHog Slack app from a Slack thread asking to unwind the trigger from feat(devex): local greptile review before opening a PR #88409 until seats are sorted.
  • Scope decision: the ask named AGENTS.md, but the PR-template bullet and the preflight nudge point agents at the same command, so all three go. The skill is narrowed rather than deleted, so the flow is ready to re-enable once seats or SSO exist.
  • No local Greptile review ran, for the reason this PR exists.

Created with PostHog from a Slack thread

The local Greptile review needs a per-person seat on PostHog's Greptile
workspace, and seats are granted by hand today. Instructing every agent to
run it before opening a PR sends most people through a sign-up flow that
creates their own workspace instead.

Drop the always-invoke wiring (AGENTS.md section, mandatory-skill entry, PR
template bullet, ci:preflight nudge) and make the skill opt-in. The command
itself and the PR bot are unchanged.

Generated-By: PostHog Desktop
Task-Id: 67296b75-291f-4056-bc95-d9f93e4785f6
@trunk-io

trunk-io Bot commented Aug 27, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 CI report

⚠️ Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

@trunk-io

trunk-io Bot commented Aug 27, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@gantoine
gantoine marked this pull request as ready for review August 27, 2026 12:19
Copilot AI lite review requested due to automatic review settings August 27, 2026 12:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team August 27, 2026 12:19
@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "chore(devex): stop instructing agents to..." | Re-trigger Greptile

@trunk-io
trunk-io Bot merged commit 67c9e9a into master Aug 27, 2026
291 checks passed
@trunk-io
trunk-io Bot deleted the posthog/stop-triggering-hogli-review branch August 27, 2026 12:54
@deployment-status-posthog

deployment-status-posthog Bot commented Aug 27, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-08-27 14:12 UTC Run
prod-us ✅ Deployed 2026-08-27 14:31 UTC Run
prod-eu ✅ Deployed 2026-08-28 07:22 UTC Run

gantoine added a commit that referenced this pull request Aug 28, 2026
A task that only said to open a PR matched the skill's description,
which then pointed at the harness code review. That fans out parallel
agents and cost one person over a hundred dollars on a 2,400-line diff.

#90039 and #90504 already removed the mandatory rules and the hogli
review command. Nothing else references the skill.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants