Skip to content

chore(devex): remove the greptile cli review, keep the skill - #90504

Merged
trunk-io[bot] merged 1 commit into
masterfrom
chore/remove-greptile-cli-review
Aug 28, 2026
Merged

chore(devex): remove the greptile cli review, keep the skill#90504
trunk-io[bot] merged 1 commit into
masterfrom
chore/remove-greptile-cli-review

Conversation

@gantoine

Copy link
Copy Markdown
Member

Problem

Every flox activation installs a code review CLI that almost nobody on the team can use.

  • A Greptile seat is per-person and hand-granted, so hogli review exits 78 for most people who run it.
  • The install runs on every new checkout and worktree, and adds a step to the activation output.
  • It writes a machine-shared npm store under ~/.config/posthog/tools/greptile/.
  • An agent asked for a pre-PR review had to detect that failure and fall back to its own review. That fallback is the path it should take directly.
  • chore(devex): stop instructing agents to run hogli review #90039 already removed the instructions that told agents to run the command. This removes what those instructions pointed at.

Changes

Before:

flowchart LR
  Flox{{Flox activation}} --> Install[(npm install greptile)]
  Dev{{Dev or agent}} --> Cmd["hogli review"]
  Install --> Cmd
  Cmd -->|no seat: exit 78| Fallback["Harness review"]
  Cmd -->|reviewed| Label[Open PR with no-greptile]
  Fallback --> Open[Open PR]
  classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff;
  classDef phRed fill:#f54e00,stroke:#f54e00,color:#fff;
  classDef phYellow fill:#f9bd2b,stroke:#f9bd2b,color:#000;
  classDef phGray fill:#e5e7eb,stroke:#c7ccd1,color:#000;
  class Dev,Flox phBlue;
  class Cmd phRed;
  class Label,Open phYellow;
  class Install,Fallback phGray;
Loading

After:

flowchart LR
  Dev{{Dev or agent}} --> Review["Harness review"]
  Review --> Edits[(Pre-push edits)]
  Edits --> Open[Open PR]
  Open --> Bot{{PR review bot}}
  classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff;
  classDef phRed fill:#f54e00,stroke:#f54e00,color:#fff;
  classDef phYellow fill:#f9bd2b,stroke:#f9bd2b,color:#000;
  classDef phGray fill:#e5e7eb,stroke:#c7ccd1,color:#000;
  class Dev,Review phBlue;
  class Bot phRed;
  class Open phYellow;
  class Edits phGray;
Loading
  • Flox activation stops installing the Greptile CLI. The activation output loses its "Greptile CLI" step, and a fresh worktree skips the npm install.
  • hogli review is gone, so hogli no longer lists it.
  • The reviewing-before-pr skill now runs the harness's own review over the branch diff. In Claude Code that is /code-review.
  • Anyone can run that review, so the skill no longer gates itself on Greptile access.
  • The skill drops the no-greptile labeling gate. Every PR keeps its bot review, and no local pass can suppress one.
  • The .greptile/ bot config stays, at the root and in products/desktop/. The PR bot reads it, and it is not part of the CLI.
  • Mechanical: .env.local.example drops GREPTILE_API_KEY, and the command's tests go with the command.

Nothing in the product changes. All surfaces are dev tooling: hogli, flox activation, and one agent skill.

How did you test this code?

  • hogli lint:skills passes on the rewritten skill.
  • The .flox/env/on-activate.sh deletion is the exact inverse of the 57 lines feat(devex): local greptile review before opening a PR #88409 added, and bash -n parses the result.
  • hogli ci:preflight --strict reports no failures, and the pre-push hook ran it.
  • No new tests. The two deleted test files covered hogli review, which no longer exists.
  • Not checked: a real flox activation, which needs a fresh entry into the environment. The removed block only ran during activation, so CI does not cover it either.

Automatic notifications

  • Publish to changelog?

Docs update

None. docs/ never documented the command, for the reason #88409 recorded: this workflow family lives in AGENTS.md and .agents/skills/.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

  • Built with Claude Code (Opus 5), directed by the assignee.
  • Skills invoked: /writing-skills, /writing-pr-descriptions.
  • The .greptile/ config directory was the one judgment call. feat(devex): local greptile review before opening a PR #88409 moved the bot config out of greptile.json so the CLI and bot could share it, and reverting that move would churn a live integration for no gain, so the directory stays and owners.yaml keeps pointing at it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@gantoine gantoine added the skip-inkeep-docs Use this label to skip an Inkeep docs PR in posthog.com label Aug 27, 2026
@trunk-io

trunk-io Bot commented Aug 27, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@gantoine gantoine self-assigned this Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 CI report

🚨 Trunk lane — universal lane

This PR is assigned to the universal lane. It cannot merge in parallel with other PRs, so it can take longer to merge. Ask dev-ex if you think this is wrong.

@gantoine
gantoine marked this pull request as ready for review August 27, 2026 21:29
Copilot AI lite review requested due to automatic review settings August 27, 2026 21:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gantoine
gantoine requested a review from a team August 27, 2026 21:29
@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "chore(devex): remove the greptile cli re..." | Re-trigger Greptile

@trunk-io

trunk-io Bot commented Aug 27, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@trunk-io
trunk-io Bot merged commit eed308f into master Aug 28, 2026
305 of 312 checks passed
@trunk-io
trunk-io Bot deleted the chore/remove-greptile-cli-review branch August 28, 2026 13:23
@deployment-status-posthog

deployment-status-posthog Bot commented Aug 28, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-08-28 13:45 UTC Run
prod-us ✅ Deployed 2026-08-28 14:05 UTC Run
prod-eu ✅ Deployed 2026-08-28 14:04 UTC Run

gantoine added a commit that referenced this pull request Aug 28, 2026
A task that only said to open a PR matched the skill's description,
which then pointed at the harness code review. That fans out parallel
agents and cost one person over a hundred dollars on a 2,400-line diff.

#90039 and #90504 already removed the mandatory rules and the hogli
review command. Nothing else references the skill.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-inkeep-docs Use this label to skip an Inkeep docs PR in posthog.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants