chore(devex): delete the reviewing-before-pr skill - #90912
Merged
Conversation
gantoine
added
the
skip-agent-review
|
😎 Merged successfully - details. |
gantoine
marked this pull request as ready for review
August 28, 2026 14:02
Contributor
🤖 CI report✅ Trunk lane — non-backend laneThis PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes. |
Contributor
|
Reviews (1): Last reviewed commit: "chore(devex): remove the reviewing-befor..." | Re-trigger Greptile |
gantoine
force-pushed
the
chore/remove-local-greptile-review
branch
from
August 28, 2026 14:06
4b8a49d to
07b81ba
Compare
gantoine
changed the title
gantoine
marked this pull request as draft
August 28, 2026 14:06
A task that only said to open a PR matched the skill's description, which then pointed at the harness code review. That fans out parallel agents and cost one person over a hundred dollars on a 2,400-line diff. #90039 and #90504 already removed the mandatory rules and the hogli review command. Nothing else references the skill. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gantoine
force-pushed
the
chore/remove-local-greptile-review
branch
from
August 28, 2026 14:07
07b81ba to
503af4e
Compare
gantoine
changed the title
gantoine
marked this pull request as ready for review
August 28, 2026 14:15
Contributor
|
Reviews (2): Last reviewed commit: "chore(devex): delete the reviewing-befor..." | Re-trigger Greptile |
mayteio
approved these changes
Aug 28, 2026
tatoalo
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An agent told only to build a feature and open a PR ran a full local code review on its own. It fanned out parallel agents over a 2,400-line diff and spent over a hundred dollars of one person's tokens. Nobody asked for it.
The
reviewing-before-prskill described itself as covering "a review before opening or pushing a PR". A task that says to open a PR matches that. The skill then names/code-reviewas the thing to run, so a routine instruction reached an expensive fan-out with no one deciding to spend.Changes
.agents/skills/reviewing-before-pr/SKILL.md, the last file from feat(devex): local greptile review before opening a PR #88409./code-reviewis a harness skill and needs nothing from this repo.Narrowing the description was the alternative. Deleting wins because the skill's remaining content is "run
/code-review, then write the findings in the PR description", which an agent does not need a skill to be told.#90039 removed the mandatory AGENTS.md entry and the PR-template rule. #90504 removed the
hogli reviewcommand. Nothing else in the repo references the skill, so this is the last piece.How did you test this code?
grep -rn reviewing-before-prover the tree returns nothing after the deletion.hogli ci:preflight --strictpasses on the branch.hogli review.Automatic notifications
Docs update
None. The skill is agent guidance under
.agents/skills/, and nothing underdocs/describes it.🤖 Agent context
Autonomy: Human-driven (agent-assisted)