refactor(qt): make NVST presentation shell-owned - #785
Merged
zortos293 merged 1 commit intoAug 30, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zortos293
merged commit Aug 30, 2026
fd26559
into
t3code/redesign-open-now-framework
5 of 17 checks passed
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamSurfaceControllerthat owns stream-host discovery, stable handle/geometry updates, DPR-aware physical presentation bounds, logical capture bounds, deduplication, reconnect replay, overlay visibility, and stale-handle-free teardownThis is stacked on #781 because it is a focused follow-up to the Qt rebuild branch.
Validation
cmake --build /home/user/.capy/work/opennow-qt-build -j2ctest --test-dir /home/user/.capy/work/opennow-qt-build --output-on-failure— 60/60 passedcargo fmt --all -- --check,cargo clippy --locked --all-targets -- -D warnings, andcargo test --locked --all-targetsinnative/opennow-corecargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings,cargo check --workspace, andcargo test --workspaceinnative/opennow-streamernpm --prefix opennow-stable run locales:check— 891 used keys checkedgit diff --checkA Linux-hosted macOS cross-check was blocked before project compilation because the environment has no Apple C toolchain/SDK (
ccrejected-archand-mmacosx-version-min). The macOS CI runners and required real-device acceptance remain the authoritative checks for that path.