fix(qt): render NVST frames in the Qt scene graph - #787
Merged
zortos293 merged 1 commit intoAug 31, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zortos293
merged commit Aug 31, 2026
1ed01b1
into
t3code/redesign-open-now-framework
5 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the external presenter contract introduced by #785 and #786.
cdyliband a bounded, versioned C ABI; keepopennow-coreout of process for account and session preparation only.QQuickRhiItemusing Qt-owned D3D11, Metal, or Vulkan devices and Qt's active command stream, with explicit frame lifetime, synchronization, device-loss, pause, reconnect, and scene-graph teardown handling.Verification:
cargo fmt --all -- --check, workspace Clippy with-D warnings, and workspace tests fornative/opennow-streamercargo fmt --all -- --check, Clippy with-D warnings, and all tests fornative/opennow-corenpm run locales:check(891 keys)git diff --checkDT_NEEDEDforlibopennow_streamer_ffi.so, resolves it from$ORIGIN, excludesopennow-streamer, and passes an offscreen smoke launch from outside the build treeTarget-OS builds and real-device NVST acceptance remain required for Windows D3D11, macOS Metal, and Linux Vulkan presentation, including overlays, display/DPI changes, reconnect, device loss, teardown, input, and four-gamepad behavior.