Skip to content

fix(qt): embed Windows NVST presenter as child HWND - #786

Merged
zortos293 merged 1 commit into
t3code/redesign-open-now-frameworkfrom
capy/windows-qt-child-surface
Aug 30, 2026
Merged

fix(qt): embed Windows NVST presenter as child HWND#786
zortos293 merged 1 commit into
t3code/redesign-open-now-frameworkfrom
capy/windows-qt-child-surface

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

Corrects the Windows presentation contract introduced by #785.

  • Reparent the out-of-process SDL presenter with SetParent, convert it to a borderless WS_CHILD, and position it with Qt-host-local physical geometry.
  • Preserve focus and Raw Input ownership through the Qt parent HWND, while suspending keyboard, mouse, and gamepad forwarding whenever the presenter is hidden or the session is paused.
  • Make overlay opening wait for the hide/input-release acknowledgement, and make Qt surface teardown wait for checked presenter detachment.
  • Report Windows honestly as embedded-child; this remains an out-of-process child HWND, not a Qt Quick scene-graph texture. Other platforms remain paired auxiliary windows.

Verification:

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo check --workspace
  • cargo test --workspace
  • cargo check -p opennow-streamer-platform --target x86_64-pc-windows-gnu with LLVM-MinGW 18
  • Full Qt CMake build and ctest (60/60 passed)
  • git diff --check

Real-Windows runtime acceptance is still required to prove taskbar/top-level behavior, DPI/display transitions, fullscreen, overlay hide/restore, native input, reconnect, and teardown against an active NVST stream.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b6671353-76c8-41f5-95f0-502fdab2c81d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zortos293
zortos293 merged commit 079f544 into t3code/redesign-open-now-framework Aug 30, 2026
6 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant