fix(qt): embed Windows NVST presenter as child HWND - #786
Merged
zortos293 merged 1 commit intoAug 30, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zortos293
merged commit Aug 30, 2026
079f544
into
t3code/redesign-open-now-framework
6 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the Windows presentation contract introduced by #785.
SetParent, convert it to a borderlessWS_CHILD, and position it with Qt-host-local physical geometry.embedded-child; this remains an out-of-process child HWND, not a Qt Quick scene-graph texture. Other platforms remain paired auxiliary windows.Verification:
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo check --workspacecargo test --workspacecargo check -p opennow-streamer-platform --target x86_64-pc-windows-gnuwith LLVM-MinGW 18ctest(60/60 passed)git diff --checkReal-Windows runtime acceptance is still required to prove taskbar/top-level behavior, DPI/display transitions, fullscreen, overlay hide/restore, native input, reconnect, and teardown against an active NVST stream.