core: establish the private canonical Program spine - #465
Merged
Conversation
- admit correlated scenario sets once behind shared immutable backing - make joint selection domain-safe, linear, and ownership-retryable - refresh source-bound release proof gates
- keep allocation tests ownership-preserving without a large Result closure - pin the zero-headroom WASM ratchet to the reproducible V2a artifact
Keep only the private Program compiler/lowering payload for the direct sole-Session bridge. Delete the duplicate owner, lifecycle, output materialization, and test evaluator scaffolding. Pin the hard cut with a negative facade gate and refresh the exact point-support source receipt.
Replace the point-support-specific lifecycle with one sealed monomorphized Session, attach reusable CompiledProgram epochs through strong ownership, and retain complete case-by-constraint reports. Bind every decision to the exact admitted observation before atomic commit and refresh release proof pins.
|
✅ Action performedReview finished.
|
lemone112
marked this pull request as ready for review
July 26, 2026 19:13
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/verify_program_public_surface.py`:
- Around line 129-160: Уточните сообщение RustdocShapeError в функции
program_public_surface() при source_links == 0: явно укажите, что не найден
compiler-emitted source link с ожидаемым классом rustdoc и возможна
несовместимость разметки или версии toolchain. Остальную проверку ссылок и
поведение функции не изменяйте.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8bb669f7-138d-4737-a5ab-af933f566b53
📒 Files selected for processing (7)
.github/workflows/ci.ymlcrates/labcolors-core/src/generic_boundary_tests.rscrates/labcolors-core/src/program.rspackages/colors/bench/wasm.jsonscripts/check-wasm-size-budget.mjsscripts/test_program_public_surface.pyscripts/verify_program_public_surface.py
This was referenced Jul 26, 2026
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The product had useful point-graph, occurrence, evaluator, and Session work split across a legacy recipe runtime and an unfinished second public
Programroot. Merging the stacked slices one by one would expose that second root before the terminal C7c cutover.Cumulative outcome
This PR is the only merge candidate for the superseded #448–#461, #463, and #464 stack. Relative to
main, it:No public replacement API, compatibility layer, or new recipe variant is introduced.
Architectural invariants
RED → GREEN highlights
use crate::program as staged; pub use staged::DraftV1 as ...bypassed the old text guard; crate-private items plus resolved-rustdoc origin tracing now reject it;Verification
Exact head:
dcd49435df1a0a07e20ac345d6488081e08119d7.main; lower drafts will be closed as superseded after squash merge.The exact WASM budget is bound to the canonical Linux artifact; the final visibility cut does not alter runtime bytes.
Summary by CodeRabbit
Изменения API
Проверки и качество
Производительность