core: bind Program reports to alpha-invariant content identity - #457
Closed
lemone112 wants to merge 4 commits into
Closed
core: bind Program reports to alpha-invariant content identity#457lemone112 wants to merge 4 commits into
lemone112 wants to merge 4 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughДобавлена контентная identity ChangesКонтентная identity программы
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant Program
participant ProgramSession
participant GraphBuilderV1
participant Canonicalizer
participant SHA256
participant ProgramReportV1
ProgramSession->>GraphBuilderV1: build_graph(program)
GraphBuilderV1->>Canonicalizer: canonical_preimage(graph)
Canonicalizer->>SHA256: digest(preimage)
SHA256-->>ProgramSession: ProgramContentIdentityV1
ProgramSession->>ProgramReportV1: сохраняет content_identity
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/labcolors-core/src/program_identity.rs`:
- Around line 396-400: В обновлении кодирования вокруг вызова color.push_u8
используйте именованные константы вместо встроенных значений 1, 2 и 3 для
вариантов SurroundProfileId::{AverageV1, DimV1, DarkV1}. Разместите константы в
подходящем пространстве имён или модуле, согласовав их с существующим
release_tag::* подходом, и сохраните текущие числовые значения и порядок
кодирования.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c8455660-1cca-48e6-a996-19a4d2cb6306
📒 Files selected for processing (10)
crates/labcolors-core/src/constraints/exact.rscrates/labcolors-core/src/constraints/mod.rscrates/labcolors-core/src/constraints/wcag22.rscrates/labcolors-core/src/generic_boundary_tests.rscrates/labcolors-core/src/lib.rscrates/labcolors-core/src/program_identity.rscrates/labcolors-core/src/program_identity_tests.rscrates/labcolors-core/src/program_joint_integration_tests.rscrates/labcolors-core/src/program_session.rscrates/labcolors-core/src/sha256.rs
…fact The exact-length gate still pinned 376830B from `canonical-authored-program-lowerer` (#456, run 29971399220). This slice grew the runtime artifact to 376985B and did not carry the re-pin that every earlier stacked slice performed (#450, #452, #454, #456), so the gate has rejected this head and every head above it. The +155B is attributable to this slice alone: runs 30115821523 (#457), 30124467410 (#458), 30125634830 (#459), 30129537515 (#460) and 30136346868 (#461) all measure exactly 376985B, so #458-#461 contribute zero bytes to the artifact and were failing only on the inherited pin. The new measurement is the CI run for this exact head (39ee0a7), not a local build: the canonical platform is linux-x64 and a local arm64 build only produces a DIAGNOSTIC result. The budget file's own SHA-256 is re-pinned in the checker so the drift gate keeps rejecting unattributed edits. Co-Authored-By: Claude <noreply@anthropic.com>
This slice moves files inside the point-support semantic cone, so the capsule digest and the committed surplus proof move with it. Both are now regenerated in the same commit that causes the drift, matching the convention the rest of the stack follows; previously the re-bind was batched at #460, which left #457-#459 fail-closed on their own heads and made the stack unmergeable in order. Numerical review: every proof field is unchanged. Only the source-binding identities move -- the file hashes of the cone files this slice edits, the resulting closure digest, the verifier hash and the rolled-up payload hash. The surplus mathematics is byte-identical. Co-Authored-By: Claude <noreply@anthropic.com>
lemone112
added a commit
that referenced
this pull request
Jul 26, 2026
This slice moves files inside the point-support semantic cone, so the capsule digest and the committed surplus proof move with it. Both are now regenerated in the same commit that causes the drift, matching the convention the rest of the stack follows; previously the re-bind was batched at #460, which left #457-#459 fail-closed on their own heads and made the stack unmergeable in order. Numerical review: every proof field is unchanged. Only the source-binding identities move -- the file hashes of the cone files this slice edits, the resulting closure digest, the verifier hash and the rolled-up payload hash. The surplus mathematics is byte-identical. Co-Authored-By: Claude <noreply@anthropic.com>
lemone112
added a commit
that referenced
this pull request
Jul 26, 2026
This slice moves files inside the point-support semantic cone, so the capsule digest and the committed surplus proof move with it. Both are now regenerated in the same commit that causes the drift, matching the convention the rest of the stack follows; previously the re-bind was batched at #460, which left #457-#459 fail-closed on their own heads and made the stack unmergeable in order. Numerical review: every proof field is unchanged. Only the source-binding identities move -- the file hashes of the cone files this slice edits, the resulting closure digest, the verifier hash and the rolled-up payload hash. The surplus mathematics is byte-identical. Co-Authored-By: Claude <noreply@anthropic.com>
lemone112
added a commit
that referenced
this pull request
Jul 26, 2026
* feat(core): compile generic point-render sessions * fix(core): satisfy format and all-target lint gates * perf(core): recycle point-render session buffers * style(core): format reusable session buffers * feat(lcs): execute sealed sRGB8 tristimulus derivation * style(lcs): format sealed tristimulus slice * feat(lcs): derive versioned appearance views * style(lcs): canonicalize Oklab coefficient * feat(core): expose typed terminal program path * fix(core): satisfy terminal Program quality gates * feat(lcs): bind private output projection registry * style(core): canonicalize release module order * fix(core): scope private registry lint firewall * fix(core): harden terminal Program admission * style(core): match pinned Rust formatter * feat(core): bind F0 release descriptors * perf(core): add linear canonical surface ingestion * refactor(core): unify terminal physical identities * perf(core): prebind terminal evaluation slots * perf(core): make present ingestion lazy and borrowed * refactor(core): remove per-port surface mutation * feat(core): evaluate typed constraints and emit terminal paints * feat(core): bind observation groups to runtime streams * refactor(core): share one encoded point Paint value * refactor(core): share revision-bound observation state - admit correlated scenario sets once behind shared immutable backing - make joint selection domain-safe, linear, and ownership-retryable - refresh source-bound release proof gates * fix(ci): bind V2a budget to measured artifact - keep allocation tests ownership-preserving without a large Result closure - pin the zero-headroom WASM ratchet to the reproducible V2a artifact * refactor(core): remove superseded Program runtime Keep only the private Program compiler/lowering payload for the direct sole-Session bridge. Delete the duplicate owner, lifecycle, output materialization, and test evaluator scaffolding. Pin the hard cut with a negative facade gate and refresh the exact point-support source receipt. * feat(core): execute compiled plans through sole Session Replace the point-support-specific lifecycle with one sealed monomorphized Session, attach reusable CompiledProgram epochs through strong ownership, and retain complete case-by-constraint reports. Bind every decision to the exact admitted observation before atomic commit and refresh release proof pins. * feat(core): bind Program assessments to context-bound LCS * Hard-delete Pair taxonomy from shipping surfaces * Compile typed finite targets into Program sessions * quarantine unsupported Display P3 promises * core: make compiled programs the sole session-generation owner * core: close the evaluator union and package session bridge * core: derive a typed CAM16-UCS occurrence view * core: lower authored physical declarations into the canonical Program * core: bind Program content identity * core: name versioned identity discriminants * fix(ci): re-pin the runtime WASM budget to this slice's measured artifact The exact-length gate still pinned 376830B from `canonical-authored-program-lowerer` (#456, run 29971399220). This slice grew the runtime artifact to 376985B and did not carry the re-pin that every earlier stacked slice performed (#450, #452, #454, #456), so the gate has rejected this head and every head above it. The +155B is attributable to this slice alone: runs 30115821523 (#457), 30124467410 (#458), 30125634830 (#459), 30129537515 (#460) and 30136346868 (#461) all measure exactly 376985B, so #458-#461 contribute zero bytes to the artifact and were failing only on the inherited pin. The new measurement is the CI run for this exact head (39ee0a7), not a local build: the canonical platform is linux-x64 and a local arm64 build only produces a DIAGNOSTIC result. The budget file's own SHA-256 is re-pinned in the checker so the drift gate keeps rejecting unattributed edits. Co-Authored-By: Claude <noreply@anthropic.com> * fix(ci): re-bind the point-support source capsule to this slice's cone This slice moves files inside the point-support semantic cone, so the capsule digest and the committed surplus proof move with it. Both are now regenerated in the same commit that causes the drift, matching the convention the rest of the stack follows; previously the re-bind was batched at #460, which left #457-#459 fail-closed on their own heads and made the stack unmergeable in order. Numerical review: every proof field is unchanged. Only the source-binding identities move -- the file hashes of the cone files this slice edits, the resulting closure digest, the verifier hash and the rolled-up payload hash. The surplus mathematics is byte-identical. Co-Authored-By: Claude <noreply@anthropic.com> * core: project complete program certificate evidence * fix(ci): re-bind the point-support source capsule to this slice's cone This slice moves files inside the point-support semantic cone, so the capsule digest and the committed surplus proof move with it. Both are now regenerated in the same commit that causes the drift, matching the convention the rest of the stack follows; previously the re-bind was batched at #460, which left #457-#459 fail-closed on their own heads and made the stack unmergeable in order. Numerical review: every proof field is unchanged. Only the source-binding identities move -- the file hashes of the cone files this slice edits, the resulting closure digest, the verifier hash and the rolled-up payload hash. The surplus mathematics is byte-identical. Co-Authored-By: Claude <noreply@anthropic.com> * core: bind Program operations to exact owner snapshots * fix(ci): re-bind the point-support source capsule to this slice's cone This slice moves files inside the point-support semantic cone, so the capsule digest and the committed surplus proof move with it. Both are now regenerated in the same commit that causes the drift, matching the convention the rest of the stack follows; previously the re-bind was batched at #460, which left #457-#459 fail-closed on their own heads and made the stack unmergeable in order. Numerical review: every proof field is unchanged. Only the source-binding identities move -- the file hashes of the cone files this slice edits, the resulting closure digest, the verifier hash and the rolled-up payload hash. The surplus mathematics is byte-identical. Co-Authored-By: Claude <noreply@anthropic.com> * core: single-own compiled observation schemas * chore(proof): document Python 3.9 zip invariant * core: define the public Program API * core: address Program API review * fix(ci): re-bind public Program proof capsule * test: close compile-fail sentinel escape * core: make joint order non-empty by construction and bound evidence cells `AdmittedFiniteJointOrderV1` stored one flat tuple slice, so an empty admitted order was representable and the evaluation path carried a runtime `state_count == 0 -> InternalInvariant` guard to reject it. The guard proved nothing about the type; it only re-checked a property the constructor already enforced. Split the order into `first + rest`. Non-emptiness becomes structural, `state_count()` is total, and the `InternalInvariant` branch in `prepare_program_evaluation_buffers` is deleted rather than left dead. The `joint_state_count: Option<usize>` parameter disappears with it: cell counts are now derived from the epoch itself. The same pass stops reserving an exhaustive-conflict buffer that no constraint can ever fill. `can_conflict` is false when every compiled constraint is report-only, so a report-only program no longer reserves `cases x constraints x states` cells and no longer reports `ResourceExhausted` for a conflict it cannot produce. `OwnerV1::evidence_cell_bounds` exposes the same arithmetic as a pure preflight, with `EvidenceBoundsErrorV1::CardinalityOverflow` as the only closed failure. It creates no Session and mutates no state. Verified locally on the CI-pinned toolchain: full workspace tests green, `cargo fmt --all --check` and `cargo clippy --workspace --all-targets -- -D warnings` clean. Co-Authored-By: Claude <noreply@anthropic.com> * docs: explain packed proof invariants * core: fail closed without current Program evidence * core: revoke outputs on unknown session handoff * core: keep incomplete Program crate-private * perf: bind smaller private Program wasm * core: make staged Program unexportable * ci: explain rustdoc surface mismatch --------- Co-authored-by: Claude <noreply@anthropic.com>
Collaborator
Author
|
Superseded by the reviewed cumulative squash merge #465 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что изменено
ProgramContentIdentityV1: SHA-256 от точного канонического прообраза полного исполняемого Program.Почему
До этого эквивалентные перекомпиляции давали одинаковую физику, но report нельзя было связать с содержимым скомпилированной программы независимо от случайных клиентских имён и поколения владельца. Обычный hash отсортированных структур нарушил бы alpha-renaming. Поэтому identity строится как точный typed colored-graph canon, а не как набор ad-hoc правил для ID.
Доказательства
Проверено на точном head:
cargo test --workspace --lockedcargo test -p labcolors-core --test lint_parity --lockedgit diff --checkНезависимые architecture, API/test и performance/resource ревью: PASS после закрытия замечания о полном V1 golden.
Граница среза
Stacked draft поверх #456, часть terminal hard cut #419. Не сливать отдельно: следующий срез обязан сохранить lossless typed certificates на package boundary и сделать boundary действительно private. Production resource profile exact-canon остаётся за измерительным gate #429; этот PR намеренно не вводит недоказанный numeric cap.
Summary by CodeRabbit
Новые возможности
Исправления
Тесты