core: make compiled programs the sole session-generation owner - #453
Closed
lemone112 wants to merge 1 commit into
Closed
core: make compiled programs the sole session-generation owner#453lemone112 wants to merge 1 commit into
lemone112 wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
Author
|
Superseded by the reviewed cumulative squash merge #465 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompiledProgramthe sole strong owner of immutableProgramEpochV1; everyProgramSessionPlanholds onlyWeak.Session::update. A dropped or replaced generation returns typedSessionUpdateError::OwnerExpiredbefore observation admission, raw-head/lifecycle mutation, composition, or evaluator work.Scope
8391d227…),+367/-65.composition.rs,lib.rs,constraints/*, compatibility fallback, or package wrapper change.OwnerExpiredexplicitly.Regression coverage
Verification
cargo test -p labcolors-core--all-targets -- -D warningsThis is a stacked draft. Review only against
agent/p3-promise-hard-delete; do not merge independently.