fix(riscv): require aligned starting register for segment ops - #263
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
fix(riscv): require aligned starting register for segment ops#263carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Member
|
Thanks for the report and patch. I independently reproduced and validated this issue, then reimplemented the accepted behavior with shared direct/SMIR validation and expanded tests in #296. That rollup includes your co-author credit and asks for your review. I’m closing this PR as superseded by #296 so the fixes can be reviewed and merged as one coherent change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258
Summary
For vector segment load/store instructions (
vlseg*/vsseg*), each field is stored in a register group ofEMUL = EEW/SEW * LMULregisters starting atvd, andvdmust name the lowest-numbered register of the first field group. The affectedVlseg/Vsseghandler checked only that a field group fits in the register file (emul_regs > 8,nf*emul_regs > 8,vd + nf*emul_regs > 32); it never checkedvd % emul_regs == 0, so reserved encodings such asvlseg2e16.v v3, (a0)with EEW=16 and LMUL=1 were executed. QEMU raises SIGILL for the same encodings.The fix adds the missing
vd % emul_regs == 0check to the segment legality test.Validation
cargo test --lib: the targeted segment tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.