fix(riscv): require aligned index group for vrgatherei16.vv - #251
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
fix(riscv): require aligned index group for vrgatherei16.vv#251carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Member
|
Thank you for reporting #246 and proposing a fix. This is now independently consolidated in #255, including exact rational index EMUL, group alignment/bounds, destination overlap, and mixed-EEW source aliasing with direct, SMIR/JIT, and QEMU coverage. To keep review and CI focused on one rollup, I am closing this PR in favor of #255. You are credited as co-author on the rollup commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): require aligned index group for vrgatherei16.vv
Closes #246
Summary
vrgatherei16.vvuses EEW=16 indices withEMUL = ceil(LMUL*16/SEW), and the RISC-V V extension requires every vector register group to be named by its lowest-numbered register (riscv-v-spec, Section 6.3). The affectedVrgather | Vrgatherei16branch checked destination/source overlap but never validatedvs1 % idx_regs == 0, so reserved encodings such asvrgatherei16.vv v16, v8, v1with e32/m4 (index EMUL=2, vs1=1) were executed. QEMU raises SIGILL for the same encodings.The fix rejects any
vs1that is not aligned to the index EMUL, for both thevrgatherei16.vvandvrgather.vvforms.Validation
cargo test --lib: the targeted vrgatherei16 alignment tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.