fix(riscv): reject illegal compressed encodings at the native boundary - #239
Closed
carlosqwqqwq wants to merge 2 commits into
Closed
fix(riscv): reject illegal compressed encodings at the native boundary#239carlosqwqqwq wants to merge 2 commits into
carlosqwqqwq wants to merge 2 commits into
Conversation
cpu.rs exceeded the AGENTS.md hard split triggers (2000 lines / 150 kB). Move the vector (RVV) element access and data-path execution group, including set_vtype, into cpu/vector.rs with no behavior change.
Member
|
Thank you for reporting and proposing this fix. I independently reimplemented and validated fail-closed native admission for predecoded illegal compressed instructions across O0 and O2 in the consolidation PR #231; no commits or code from this branch were taken. The rollup carries @carlosqwqqwq as co-author on its commits and includes direct and native regression coverage. I’m closing this PR as superseded by #231—please review the consolidated implementation there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): reject illegal compressed encodings at the native boundary
Closes #238
Summary
Under RV64GC, the reserved compressed encoding
C.LUI rd=x0(raw 0x6005) is admitted and retired by the translated/JIT path instead of raising an illegal-instruction trap (cause 2). The hand-written compressed lifter dispatches by quadrant/funct3 andlift_c_lui_addi16sp()produces empty ops forrd=x0; the empty block is accepted by the native path and retired. The same admission gap coversC.ADDIW rd=x0, reserved RV32C shift encodings, and Zcb aliases when M/Zbb/Zba are missing.The fix rejects
Insn::Illegalfirst at the decoded native boundary so the encoding falls back to the interpreter, which delivers the precise trap and mtval.Validation
jit_does_not_admit_illegal_compressed_encodingfails on the base checkout and passes with the fix.cargo test --lib: full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.