fix(riscv): count only retired instructions in instret - #233
Closed
carlosqwqqwq wants to merge 2 commits into
Closed
fix(riscv): count only retired instructions in instret#233carlosqwqqwq wants to merge 2 commits into
carlosqwqqwq wants to merge 2 commits into
Conversation
cpu.rs exceeded the AGENTS.md hard split triggers (2000 lines / 150 kB). Move the vector (RVV) element access and data-path execution group, including set_vtype, into cpu/vector.rs with no behavior change.
Member
|
Thank you for reporting and proposing this fix. I independently reimplemented and validated precise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): count only retired instructions in instret
Closes #232
Summary
The retired-instruction counter counts instructions that retire. An ECALL or EBREAK leaves the interpreter through a non-
Continueexit and must not be counted as a normally retired instruction. The affectedstep()path incrementsinstretafter every successfulexecute()return, includingEcallandEbreak; the JIT fallback repeated the same rule. This makes counter observations differ between an architectural guest and RAX, and can affect code using instret for profiling or progress accounting.The fix increments
instretonly forContinueandWfiexits, while preserving the existing cycle counter increment.Validation
ecall_ebreak_do_not_increment_instretfails on the base checkout and passes with the fix.cargo test --lib: full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.