Skip to content

test: cover header row visibility with null header and header renderer #12179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
web-padawan merged 1 commit into from
Jul 17, 2026
+10 −0
Merged

test: cover header row visibility with null header and header renderer #12179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/grid/test/column.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,16 @@
expect(grid.$.header.children[0].hidden).to.be.ok;
});

it('should not hide the header row with null header and header renderer', () => {

Check failure on line 356 in packages/grid/test/column.test.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 


See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZ9wAtk0FoG4PDw3h_rj&open=AZ9wAtk0FoG4PDw3h_rj&pullRequest=12179
emptyColumn.headerRenderer = (root) => {
root.textContent = 'foo';
};
emptyColumn.header = null;
grid.removeChild(grid.querySelector('vaadin-grid-column-group'));
flushGrid(grid);
expect(grid.$.header.children[0].hidden).not.to.be.ok;
});

it('should produce an empty header cell', () => {
emptyColumn.path = 'foo';
emptyColumn.header = '';
Expand Down
Loading