test: cover header row visibility with null header and header renderer#12179
Merged
Conversation
|
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
web-padawan
approved these changes
Jul 17, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.3.0-alpha6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
headertonullhides the header row unless something else keeps it visible. When a column also has aheaderRenderer, the row must stay visible: a null header should only suppress the default header text, not hide content produced by the renderer. This behavior wasn't covered by tests, and an early version of the declarative header/footer rendering refactor accidentally broke it. This adds a test to lock in the current behavior.Extracted from #12134
Part of #10789
🤖 Generated with Claude Code