-
Notifications
You must be signed in to change notification settings - Fork 25
feat(styles): error page templates #8405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leagrdv
wants to merge
5
commits into
main
Choose a base branch
from
5847-add-additional-error-page-templates-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9b85d94
feat(styles): error page templates
leagrdv 0f2c0ec
Address PR comments
leagrdv 5f8b0f0
Merge branch 'main' into 5847-add-additional-error-page-templates-2
leagrdv 6e2a610
Merge branch 'main' into 5847-add-additional-error-page-templates-2
leagrdv e498f7f
Address PR comments
leagrdv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@swisspost/design-system-documentation': minor | ||
| '@swisspost/design-system-styles': minor | ||
| --- | ||
|
|
||
| Added different page templates for the following errors: 400, 401, 403, 404, 451, 500, 503 and 504. | ||
|
|
||
| The previous 404 error page template is now deprecated. |
7 changes: 7 additions & 0 deletions
7
apps/documentation/cypress/snapshots/components/error-page.snapshot.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| describe('ErrorPage', () => { | ||
| it('error page', () => { | ||
| cy.visit('/iframe.html?id=snapshots--error-page'); | ||
| cy.get('.error', { timeout: 30000 }).should('be.visible'); | ||
| cy.percySnapshot('Error page', { widths: [1440] }); | ||
| }); | ||
| }); |
13 changes: 5 additions & 8 deletions
13
apps/documentation/src/stories/templates/error-page/error-page.docs.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,13 @@ | ||
| import { Meta, Canvas } from '@storybook/addon-docs/blocks'; | ||
| import { Meta, Canvas, Controls } from '@storybook/addon-docs/blocks'; | ||
| import * as ErrorPageStories from './error-page.stories'; | ||
|
|
||
| <Meta of={ErrorPageStories} /> | ||
|
|
||
| # Error page template | ||
|
|
||
| A generic error page pattern with an image. The image can be exchanged based on the type of error. | ||
|
|
||
| ## Assets | ||
|
|
||
| - <a download href="/images/content/404.png"> | ||
| Download "404 not found" image | ||
| </a> | ||
| A generic error page pattern. The image is set automatically based on the container class that is set. | ||
|
|
||
| <Canvas of={ErrorPageStories.Default} sourceState="shown" /> | ||
| <div className="hide-col-default"> | ||
| <Controls of={ErrorPageStories.Default} /> | ||
| </div> |
26 changes: 26 additions & 0 deletions
26
apps/documentation/src/stories/templates/error-page/error-page.snapshot.stories.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import type { Args, StoryContext, StoryObj } from '@storybook/web-components-vite'; | ||
| import meta from './error-page.stories'; | ||
| import { html } from 'lit'; | ||
| import { schemes } from '@/shared/snapshots/schemes'; | ||
|
|
||
| const { id, ...metaWithoutId } = meta; | ||
|
|
||
| export default { | ||
| ...metaWithoutId, | ||
| title: 'Snapshots', | ||
| }; | ||
|
|
||
| type Story = StoryObj; | ||
|
|
||
| export const ErrorPage: Story = { | ||
| render: (_args: Args, context: StoryContext) => { | ||
| return schemes( | ||
| () => html` | ||
| ${['400', '401', '403', '404', '451', '500', '503', '504'].map( | ||
| type => | ||
| html`<div class="mb-16">${meta.render?.({ ...context.args, type }, context)}</div>`, | ||
| )} | ||
| `, | ||
| ); | ||
| }, | ||
| }; |
166 changes: 135 additions & 31 deletions
166
apps/documentation/src/stories/templates/error-page/error-page.stories.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.