Skip to content

feat(styles): error page templates - #8405

Open
leagrdv wants to merge 5 commits into
mainfrom
5847-add-additional-error-page-templates-2
Open

feat(styles): error page templates#8405
leagrdv wants to merge 5 commits into
mainfrom
5847-add-additional-error-page-templates-2

Conversation

@leagrdv

@leagrdv leagrdv commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

📄 Description

Please include a summary of the changes made in this PR.

🚀 Demo

If applicable, please add a screenshot or video to illustrate the changes.


🔮 Design review

  • Design review done
  • No design review needed

🧪 Visual regression tests

  • Visual changes detected and approved (Check this box if VRT fails and changes are intentional)

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@leagrdv
leagrdv requested review from a team as code owners August 31, 2026 06:55
@leagrdv leagrdv linked an issue Aug 31, 2026 that may be closed by this pull request
@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e498f7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@swisspost/design-system-documentation Minor
@swisspost/design-system-styles Minor
@swisspost/design-system-integration-angular Minor
@swisspost/design-system-integration-next Minor
@swisspost/design-system-components Minor
@swisspost/internet-header Minor
@swisspost/design-system-styles-primeng Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-components-react Minor
@swisspost/design-system-changelog-github Minor
@swisspost/design-system-eslint Minor
@swisspost/design-system-icons Minor
@swisspost/design-system-theme-ag-grid Minor
@swisspost/design-system-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@leagrdv leagrdv linked an issue Aug 31, 2026 that may be closed by this pull request
5 tasks
@swisspost-bot

swisspost-bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Related Previews

@alionazherdetska alionazherdetska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error pages look cool!

Comment thread .changeset/salty-rabbits-bow.md Outdated
Comment thread apps/documentation/src/stories/templates/error-page/error-page.stories.ts Outdated
Comment thread packages/styles/src/components/error-container.scss
@alionazherdetska

alionazherdetska commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Comment thread .changeset/salty-rabbits-bow.md
Comment thread packages/styles/src/components/error-container.scss Outdated
Comment thread packages/styles/src/components/error-container.scss Outdated
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

@alionazherdetska alionazherdetska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a small suggestion: the 8 error codes are typed out by hand in four places now - the ErrorType union, contentByType's keys, and argTypes.type.options/labels. ts checks contentByType against ErrorType, but options and labels are just plain strings with nothing linking them back, so nothing stops them drifting apart. like if 502 gets added to contentByType later but someone forgets options, storybook just quietly won't offer it as a choice, no error or anything. or the other way round, adding it to options but not contentByType would throw at render time since contentByType['502'] is undefined

could just derive options from contentByType's keys instead, options: Object.keys(contentByType), so it always matches whatever's actually there and nothing needs sycing by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error page templates Add additional error page templates

3 participants