-
Notifications
You must be signed in to change notification settings - Fork 49
Improve GPU Hamming distance computation #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
felixpetschko
wants to merge
28
commits into
scverse:main
Choose a base branch
from
felixpetschko:performance/gpu-hamming-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
880a882
Add GPU hamming improvements
felixpetschko 3d40391
Change cutoff guard to <=125
felixpetschko d053bee
Add parameter guards for block size parameters
felixpetschko 5200588
Add tests for different block size parameters
felixpetschko 5b89ab2
Adapt GPUHammingDistanceCalculator doc string
felixpetschko 7718e2c
Change sequence length array data type to int32
felixpetschko 9d3252d
Avoid unnecessary dtype copies in GPU hamming transfers
felixpetschko 80ee4c5
Replace asserts with exceptions
felixpetschko dada164
Transform guarding assert into error
felixpetschko 6887bf3
Remove benchmarking option
felixpetschko 86391e7
Skip calculation of blocks under diagonal
felixpetschko 1ab2ffb
Update block skipping
felixpetschko 701b860
Update block skipping to work with tqdm
felixpetschko c82add0
Remove logic to only compute upper triangular half for symmetric resu…
felixpetschko 4884d50
Extend test cases to cover block skipping
felixpetschko efa31eb
Update changelog
felixpetschko a2bba48
Add GPU hamming integration test
felixpetschko 940d3a0
Prevent out-of-bounds writes in GPU Hamming kernel
felixpetschko d5eef6e
Handle excess blocks in GPU Hamming calculator
felixpetschko 0530c30
Support joblib blocks in GPU Hamming calculator
felixpetschko 4c9f30e
Balance symmetric distance blocks and use fixed GPU tile sizes
felixpetschko 6d22b8b
Improve GPU Hamming block sizing and buffer handling
felixpetschko c5938ab
Change parameter names
felixpetschko 7f4b593
Log tile retry info
felixpetschko 14e0bcf
Test maximum GPU Hamming cutoff
felixpetschko 9fea04d
Extend large dataset tutorial
felixpetschko 717974b
Reformat
felixpetschko 7feb2b4
Adapt input array memory management
felixpetschko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think linking to the rapids-singlecell docs for advanced usage would make sense here?