Skip to content

Always record call_trace #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emmiegit wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Always record call_trace #2702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions deepwell/src/error/convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,18 +104,11 @@ pub fn exn_error_to_rpc_error(exn_error: Exn<Error>) -> ErrorObjectOwned {
Some(TopError::CrateError(error)) => {
let error_code = error.code();
let message = error.summary();
let data = match error.error_type {
// Special case, if authentication then don't include call trace
// See comment in auth_login in endpoints/auth.rs
ErrorType::InvalidAuthentication => None,

// Normal case, provide error context
_ => Some(json!({
"call_trace": format!("{exn_error:?}"),
"code_trace": code_trace,
"extra": extra_data,
})),
};
let data = Some(json!({
"call_trace": format!("{exn_error:?}"),
"code_trace": code_trace,
"extra": extra_data,
}));
ErrorObjectOwned::owned(error_code, message, data)
}

Expand Down
Loading