Always record call_trace - #2702
Open
emmiegit wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2702 +/- ##
=======================================
Coverage 2.09% 2.09%
=======================================
Files 190 190
Lines 12204 12202 -2
=======================================
Hits 256 256
+ Misses 11948 11946 -2
🚀 New features to boost your workflow:
|
emmiegit
enabled auto-merge
February 22, 2026 13:35
Contributor
|
Hmm, I'm not familiar with the relevant code in deepwell, but I believe right now we don't have code to block showing |
emmiegit
disabled auto-merge
February 22, 2026 13:39
Member
Author
|
That's fine, we aren't in any rush to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in discussion on #2701, the
call_tracefield will be retained internally only, and so it is safe to record the data even in the case of authentication issues. (This is because only developers will be reviewing the logs and it cannot be used by attackers to determine internal authentication state).