Documented battle_anim_electric.c#2342
Open
fdeblasio wants to merge 25 commits into
Open
Conversation
fdeblasio
marked this pull request as draft
July 4, 2026 20:47
fdeblasio
force-pushed
the
moreAnimationDocumentation
branch
from
July 4, 2026 21:24
f16c910 to
d55faf1
Compare
fdeblasio
force-pushed
the
moreAnimationDocumentation
branch
2 times, most recently
from
July 4, 2026 22:09
4e89b18 to
5a74eab
Compare
fdeblasio
marked this pull request as ready for review
July 4, 2026 22:14
fdeblasio
force-pushed
the
moreAnimationDocumentation
branch
from
July 4, 2026 22:14
5a74eab to
c61e5f8
Compare
Contributor
Author
|
There's a couple unknown variables where I figured out sort of what they do, so I added documentation for that, but I'm still not knowledgeable enough to give them a good name
|
fdeblasio
force-pushed
the
moreAnimationDocumentation
branch
from
July 4, 2026 23:15
027ac9f to
79c861f
Compare
fdeblasio
force-pushed
the
moreAnimationDocumentation
branch
from
July 7, 2026 22:25
3123f69 to
d92ab97
Compare
fdeblasio
force-pushed
the
moreAnimationDocumentation
branch
from
July 7, 2026 23:05
ded82ca to
6764086
Compare
fdeblasio
force-pushed
the
moreAnimationDocumentation
branch
from
July 7, 2026 23:10
6764086 to
6d390b8
Compare
fdeblasio
marked this pull request as draft
July 7, 2026 23:11
fdeblasio
marked this pull request as ready for review
July 8, 2026 01:12
Contributor
Author
|
Finally ready for review! I was able to document all the variables except for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created macros with named variables for the sprites and anim_tasks in
src/battle_anim_electric.cand added CMD_ARGS in order to make it more clear what each animation is doingDiscord contact info
Frankfurter0