Converted more move animation magic numbers#10359
Draft
fdeblasio wants to merge 13 commits into
Draft
Conversation
fdeblasio
force-pushed
the
removeAnimMagicNumbers
branch
3 times, most recently
from
July 4, 2026 19:08
74eaf47 to
6a6dcea
Compare
fdeblasio
marked this pull request as draft
July 4, 2026 19:39
Collaborator
Author
|
Converting back into a draft since I think this should wait to be merged until after pret#2342 (and future pret PRs for other types) are merged to avoid merge conflicts when merging pret into the expansion |
fdeblasio
force-pushed
the
removeAnimMagicNumbers
branch
from
July 6, 2026 11:12
6a6dcea to
22bc753
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Converted more move animation magic numbers into variables
Also removed commented out lines of code from
data/battle_anim_scripts.sDiscord contact info
Frankfurter0