docs(v1): add comprehensive piped configuration reference#6644
Conversation
|
@mohammedfirdouss, @rahulshendre could you please kindly review this PR? Also, please let us hold this, and wait for #6584 to get merged before we can actually merge this. Thanks! |
|
@shivansh-gohem, thank you again for this. Let us work towards getting this merged. PTAL this comment |
|
|
|
The SecretManagement section says KEY_PAIR: https://github.com/pipe-cd/pipecd/blob/master/pkg/configv1/piped.go#L507 |
|
port is marked as required? But Validate() only checks name and url Should be optional. |
|
Removing chartRepositories is correct for v1, but can you add a note saying where they moved? |
rahulshendre
left a comment
There was a problem hiding this comment.
+1 to all of @mohammedfirdouss points.
One addition alongside the chartRepositories migration note: chartRegistries also moved to spec.plugins[].config on the Kubernetes plugin but isn't mentioned in the doc. source
|
Thanks for the thorough reviews, @mohammedfirdouss and @rahulshendre! Great catches on all of these. I have updated the PR with the following changes: (i) Added groups and ignoreGroups back to NotificationRoute. (ii) Added the SecretManagementKeyPair and SecretManagementGCPKMS breakdown tables. (iii) Changed port in PipedPlugin to Optional. (iv) Added an explicit note in the intro explaining that chartRepositories and chartRegistries have moved to spec.plugins[].config. The latest commit is pushed. PTAL! |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
@shivansh-gohem resolve the conflicts |
|
hey @shivansh-gohem, let's get this merged could you rebase when you get time? |
|
@shivansh-gohem, any progress on this one 👀 |
Signed-off-by: Shivansh Sahu <sahushivansh142@gmail.com>
…er review Signed-off-by: Shivansh Sahu <sahushivansh142@gmail.com>
Signed-off-by: Shivansh Sahu <sahushivansh142@gmail.com>
Signed-off-by: Shivansh Sahu <sahushivansh142@gmail.com>
b1cd327 to
be94888
Compare
|
I have rebased onto master and addressed the remaining feedback, repoId casing, hookURL XOR logic, filled SecretManagementGCPKMS, added planPreview section, fixed heading level PTAL when you have time @khanhtc1202 @mohammedfirdouss @eeshaanSA @armistcxy |
|
LGTM!. Thanks @shivansh-gohem |
|
Thank you for contributing to PipeCD, @shivansh-gohem! The changes in this pull request will be part of the upcoming release! |
What this PR does / Why we need it:
This PR provides the structured and updated v1 configuration reference for the Piped agent (
piped.config).Note: This PR was split from #6584 per maintainer request (@eeshaanSA) to keep the
ApplicationandPipedconfiguration reviews properly isolated.Key Documentation Updates:
platformProviderswith the newpluginsand nesteddeployTargetsspecifications.SecretManagement,EventWatcher, andGit.NotificationRouteandNotificationReceiver(includingNotificationReceiverSlackandNotificationReceiverWebhookper review feedback).Which issue(s) this PR fixes:
Split from #6584
Fixes #6542