Skip to content

fix(FileUpload): add aria-disabled attribute when disabled #6653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
innocenzi wants to merge 4 commits into
base: v4
Choose a base branch
from
+5 −4
Open

fix(FileUpload): add aria-disabled attribute when disabled #6653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6ad4ff
fix(file-upload): add `aria-disabled` attribute when disabled
innocenzi Jun 29, 2026
9554e5b
test: update snapshots
innocenzi Jun 29, 2026
7b754cf
Merge branch 'v4' into fix/file-upload-aria-disabled
innocenzi Jul 6, 2026
37690a8
refactor: set `aria-disabled` using `area` variant
innocenzi Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/runtime/components/FileUpload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ defineExpose({
:type="variant === 'button' ? 'button' : undefined"
:role="variant === 'button' ? undefined : 'button'"
:disabled="variant === 'button' ? disabled : undefined"
:aria-disabled="variant === 'button' ? undefined : (disabled || undefined)"
:data-dragging="isDragging"
data-slot="base"
:class="ui.base({ class: props.ui?.base })"
Expand Down
4 changes: 2 additions & 2 deletions test/components/__snapshots__/FileUpload-vue.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ exports[`FileUpload > renders with description slot correctly 1`] = `

exports[`FileUpload > renders with disabled correctly 1`] = `
"<div data-slot="root" class="relative flex flex-col">
<div role="button" data-dragging="false" data-slot="base" class="w-full flex-1 bg-default border border-default flex flex-col gap-2 items-stretch justify-center rounded-lg transition-[background] p-4 text-sm border-dashed data-[dragging=true]:bg-elevated/25 cursor-not-allowed opacity-75 outline-primary/25 focus-visible:outline-3 focus-visible:border-primary" tabindex="-1">
<div role="button" aria-disabled="true" data-dragging="false" data-slot="base" class="w-full flex-1 bg-default border border-default flex flex-col gap-2 items-stretch justify-center rounded-lg transition-[background] p-4 text-sm border-dashed data-[dragging=true]:bg-elevated/25 cursor-not-allowed opacity-75 outline-primary/25 focus-visible:outline-3 focus-visible:border-primary" tabindex="-1">
<!--v-if-->
<div data-slot="wrapper" class="flex flex-col items-center justify-center text-center px-4 py-3"><span data-slot="avatar" class="inline-flex items-center justify-center select-none rounded-full align-middle bg-elevated size-8 text-base shrink-0"><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="1em" height="1em" viewBox="0 0 16 16" data-slot="icon" class="shrink-0 text-muted"></svg></span>
<!--v-if-->
Expand All @@ -130,7 +130,7 @@ exports[`FileUpload > renders with disabled correctly 1`] = `

exports[`FileUpload > renders with disabled correctly 2`] = `
"<div data-slot="root" class="relative flex flex-col">
<div role="button" data-dragging="false" data-slot="base" class="w-full flex-1 bg-default border border-default flex flex-col gap-2 items-stretch justify-center rounded-lg transition-[background] p-4 text-sm border-dashed data-[dragging=true]:bg-elevated/25 cursor-not-allowed opacity-75 outline-primary/25 focus-visible:outline-3 focus-visible:border-primary" tabindex="-1">
<div role="button" aria-disabled="true" data-dragging="false" data-slot="base" class="w-full flex-1 bg-default border border-default flex flex-col gap-2 items-stretch justify-center rounded-lg transition-[background] p-4 text-sm border-dashed data-[dragging=true]:bg-elevated/25 cursor-not-allowed opacity-75 outline-primary/25 focus-visible:outline-3 focus-visible:border-primary" tabindex="-1">
<!--v-if-->
<div data-slot="wrapper" class="flex flex-col items-center justify-center text-center px-4 py-3"><span data-slot="avatar" class="inline-flex items-center justify-center select-none rounded-full align-middle bg-elevated size-8 text-base shrink-0"><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="1em" height="1em" viewBox="0 0 16 16" data-slot="icon" class="shrink-0 text-muted"></svg></span>
<!--v-if-->
Expand Down
4 changes: 2 additions & 2 deletions test/components/__snapshots__/FileUpload.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ exports[`FileUpload > renders with description slot correctly 1`] = `

exports[`FileUpload > renders with disabled correctly 1`] = `
"<div data-slot="root" class="relative flex flex-col">
<div role="button" data-dragging="false" data-slot="base" class="w-full flex-1 bg-default border border-default flex flex-col gap-2 items-stretch justify-center rounded-lg transition-[background] p-4 text-sm border-dashed data-[dragging=true]:bg-elevated/25 cursor-not-allowed opacity-75 outline-primary/25 focus-visible:outline-3 focus-visible:border-primary" tabindex="-1">
<div role="button" aria-disabled="true" data-dragging="false" data-slot="base" class="w-full flex-1 bg-default border border-default flex flex-col gap-2 items-stretch justify-center rounded-lg transition-[background] p-4 text-sm border-dashed data-[dragging=true]:bg-elevated/25 cursor-not-allowed opacity-75 outline-primary/25 focus-visible:outline-3 focus-visible:border-primary" tabindex="-1">
<!--v-if-->
<div data-slot="wrapper" class="flex flex-col items-center justify-center text-center px-4 py-3"><span data-slot="avatar" class="inline-flex items-center justify-center select-none rounded-full align-middle bg-elevated size-8 text-base shrink-0"><span class="iconify i-lucide:upload shrink-0 text-muted" aria-hidden="true" data-slot="icon"></span></span>
<!--v-if-->
Expand All @@ -130,7 +130,7 @@ exports[`FileUpload > renders with disabled correctly 1`] = `

exports[`FileUpload > renders with disabled correctly 2`] = `
"<div data-slot="root" class="relative flex flex-col">
<div role="button" data-dragging="false" data-slot="base" class="w-full flex-1 bg-default border border-default flex flex-col gap-2 items-stretch justify-center rounded-lg transition-[background] p-4 text-sm border-dashed data-[dragging=true]:bg-elevated/25 cursor-not-allowed opacity-75 outline-primary/25 focus-visible:outline-3 focus-visible:border-primary" tabindex="-1">
<div role="button" aria-disabled="true" data-dragging="false" data-slot="base" class="w-full flex-1 bg-default border border-default flex flex-col gap-2 items-stretch justify-center rounded-lg transition-[background] p-4 text-sm border-dashed data-[dragging=true]:bg-elevated/25 cursor-not-allowed opacity-75 outline-primary/25 focus-visible:outline-3 focus-visible:border-primary" tabindex="-1">
<!--v-if-->
<div data-slot="wrapper" class="flex flex-col items-center justify-center text-center px-4 py-3"><span data-slot="avatar" class="inline-flex items-center justify-center select-none rounded-full align-middle bg-elevated size-8 text-base shrink-0"><span class="iconify i-lucide:upload shrink-0 text-muted" aria-hidden="true" data-slot="icon"></span></span>
<!--v-if-->
Expand Down
Loading