fix(FileUpload): add aria-disabled attribute when disabled#6653
fix(FileUpload): add aria-disabled attribute when disabled#6653innocenzi wants to merge 2 commits into
aria-disabled attribute when disabled#6653Conversation
📝 WalkthroughWalkthroughIn Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
aria-disabled attribute when disabledaria-disabled attribute when disabled
benjamincanac
left a comment
There was a problem hiding this comment.
I think aria-disabled is redundant on the button variant since native disabled already covers it. The variant that actually needs it is area (a <div role="button">). Could you flip it?
:aria-disabled="variant === 'button' ? undefined : (disabled || undefined)"
❓ Type of change
📚 Description
Adds
aria-disabledto the element acting as a button insideFileUpload. My use case is supporting this: