-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Add new apps - tranche 4 - batch 4 - wallets #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eb7d131
Add wallets for Uniswap, 1inch and Bitget
Y3drk ba21693
Merge branch 'main' of https://github.com/namehash/ensawards into y3d…
Y3drk 61b670e
Add two apps from MEW --> Enkrypt and MyEtherWallet
Y3drk e0b86a1
Add two Gem and imToken wallets
Y3drk d4a0093
Add two wallets -- SafePal and TokenPocket
Y3drk fa3e8ee
Apply AI agents' suggestions, pt.1
Y3drk 46f1ec0
Rename the web MEW app and add their mobile wallet
Y3drk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md | ||
| // for additional advice on adding and modifying app benchmarks | ||
|
|
||
| import OneInchWallet from "data/apps/1inch-wallet"; | ||
| import { defineAppBenchmarks } from "data/benchmarks/registry"; | ||
| import type { BestPracticeBenchmarks } from "data/ens-best-practices/types"; | ||
|
|
||
| import depositAddresses from "./resolution/deposit-addresses"; | ||
| import ensv2ReadyResolution from "./resolution/ensv2-ready-resolution"; | ||
|
|
||
| const benchmarks = { | ||
| "ensv2-ready-resolution": ensv2ReadyResolution, | ||
| "deposit-addresses": depositAddresses, | ||
|
|
||
| // TODO: `Contract Naming` category is temporarily hidden due to unfit content, | ||
| // and so are all benchmarks belonging to it. | ||
| // We aim to fix it as soon as we have the capacity. | ||
| // See: https://github.com/namehash/ensawards/issues/222 | ||
| "display-named-smart-contracts-mainnet": { | ||
| "mainnet-interactions-display-named-smart-contracts": undefined, | ||
| }, | ||
| "display-named-smart-contracts-l2-chains": { | ||
| "l2-chain-interactions-display-named-smart-contracts": undefined, | ||
| }, | ||
| } as const satisfies BestPracticeBenchmarks; | ||
|
|
||
| defineAppBenchmarks(OneInchWallet, benchmarks); | ||
|
|
||
| export default benchmarks; |
Binary file added
BIN
+174 KB
...rds.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+847 KB
...rds.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-2.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+600 KB
...rds.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-3.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+498 KB
...rds.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-4.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+215 KB
...rds.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-5.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+217 KB
...rds.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-7.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
126 changes: 126 additions & 0 deletions
126
ensawards.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| // Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md | ||
| // for additional advice on adding and modifying app benchmarks | ||
|
|
||
| import { type AcceptanceTestBenchmarks, BenchmarkResults } from "data/benchmarks/types"; | ||
| import contributors from "data/contributors"; | ||
| import { | ||
| buildFailNoteForAT2, | ||
| buildFailNoteForAT5, | ||
| buildFailNoteForAT7, | ||
| buildNotApplicableForFailedTest, | ||
| buildNotApplicableForNonEvmChain, | ||
| buildPassNoteForAT1, | ||
| buildPassNoteForAT3, | ||
| buildPassNoteForAT4, | ||
| } from "data/ens-best-practices/resolution/deposit-addresses/notes"; | ||
|
|
||
| import { parseTimestamp } from "@ensnode/ensnode-sdk"; | ||
|
|
||
| import at1Proof from "./at-1.png"; | ||
| import at2Proof from "./at-2.gif"; | ||
| import at3Proof from "./at-3.gif"; | ||
| import at4Proof from "./at-4.gif"; | ||
| import at5Proof from "./at-5.png"; | ||
| import at7Proof from "./at-7.png"; | ||
|
|
||
| const method = 'the "send" flow'; | ||
|
|
||
| const depositAddresses = { | ||
| "at01-resolve-onchain-name": { | ||
| result: BenchmarkResults.Pass, | ||
| contributions: [ | ||
| { from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-02T10:20:57Z") }, | ||
| ], | ||
| notes: buildPassNoteForAT1({ | ||
| method, | ||
| proof: { | ||
| image: at1Proof, | ||
| alt: "1inch Wallet correctly resolves the address for vitalik.eth", | ||
| }, | ||
| }), | ||
| }, | ||
| "at02-resolve-name-needing-normalization": { | ||
| result: BenchmarkResults.Fail, | ||
| contributions: [ | ||
| { from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-02T10:20:57Z") }, | ||
| ], | ||
| notes: buildFailNoteForAT2({ | ||
| method, | ||
| proof: { | ||
| image: at2Proof, | ||
| alt: "1inch Wallet fails to resolve the address for Ξthereum.eth", | ||
| }, | ||
| extra: "The app blocked the send operation from continuing.", | ||
| }), | ||
| }, | ||
| "at03-resolve-offchain-eth-subname": { | ||
| result: BenchmarkResults.Pass, | ||
| contributions: [ | ||
| { from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-02T10:20:57Z") }, | ||
| ], | ||
| notes: buildPassNoteForAT3({ | ||
| method, | ||
| proof: { | ||
| image: at3Proof, | ||
| alt: "1inch Wallet correctly resolves the address for jesse.base.eth", | ||
| }, | ||
| }), | ||
| }, | ||
| "at04-resolve-offchain-dns-name": { | ||
| result: BenchmarkResults.Pass, | ||
| contributions: [ | ||
| { from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-02T10:20:57Z") }, | ||
| ], | ||
| notes: buildPassNoteForAT4({ | ||
| method, | ||
| proof: { | ||
| image: at4Proof, | ||
| alt: "1inch Wallet correctly resolves the address for dperri.com", | ||
| }, | ||
| }), | ||
| }, | ||
| "at05-resolve-name-on-other-evm-chain": { | ||
| result: BenchmarkResults.Fail, | ||
| contributions: [ | ||
| { from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-02T10:20:57Z") }, | ||
| ], | ||
| notes: buildFailNoteForAT5({ | ||
| method, | ||
| proof: { | ||
| image: at5Proof, | ||
| alt: "1inch Wallet fails to resolve the address for lightkeeper.eth on the Base chain", | ||
| }, | ||
| extra: "The app resolved to the Ethereum Mainnet address instead of the Base address.", | ||
| }), | ||
| }, | ||
| "at06-resolve-bitcoin-address": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-02T10:20:57Z") }, | ||
| ], | ||
| notes: buildNotApplicableForNonEvmChain({ chain: "Bitcoin" }), | ||
| }, | ||
| "at07-resolve-solana-address": { | ||
| result: BenchmarkResults.Fail, | ||
| contributions: [ | ||
| { from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-02T10:20:57Z") }, | ||
| ], | ||
| notes: buildFailNoteForAT7({ | ||
| method: 'the "send" flow in context of the Solana chain', | ||
| proof: { | ||
| image: at7Proof, | ||
| alt: "1inch Wallet fails to resolve the Solana address for gregskril.eth", | ||
| }, | ||
| extra: 'The app showed the message "Incompatible network".', | ||
| }), | ||
| }, | ||
| "at08-handle-invalid-address-format": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-02T10:20:57Z") }, | ||
| ], | ||
| notes: buildNotApplicableForFailedTest({ testNumber: 5, scope: "on Base" }), | ||
| }, | ||
| } as const satisfies AcceptanceTestBenchmarks; | ||
|
|
||
| export default depositAddresses; |
Binary file added
BIN
+189 KB
...rg/data/apps/1inch-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
45 changes: 45 additions & 0 deletions
45
ensawards.org/data/apps/1inch-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md | ||
| // for additional advice on adding and modifying app benchmarks | ||
|
|
||
| import type { AcceptanceTestBenchmark } from "data/acceptance-tests/types"; | ||
| import type { AcceptanceTestBenchmarks } from "data/benchmarks/types"; | ||
| import { BenchmarkResults } from "data/benchmarks/types"; | ||
| import contributors from "data/contributors"; | ||
| import { | ||
| acceptanceTestDetailsContainerStyles, | ||
| bestPracticeTechnicalDetailsCodeStyles, | ||
| } from "data/ens-best-practices/styles"; | ||
|
|
||
| import { parseTimestamp } from "@ensnode/ensnode-sdk"; | ||
|
|
||
| import { cn } from "@/utils/tailwindClassConcatenation"; | ||
|
|
||
| import at1ProofImage from "./at-1.png"; | ||
|
|
||
| const ensv2ReadyResolution = { | ||
| "correctly-resolve-ensv2-test-name-address": { | ||
| result: BenchmarkResults.Fail, | ||
| contributions: [ | ||
| { from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-02T09:32:00Z") }, | ||
| ], | ||
| notes: ( | ||
| <div className={cn(acceptanceTestDetailsContainerStyles, "w-full")}> | ||
| <p className="w-full"> | ||
| ENSv2 ready resolution was tested using the "send" flow. The resolved address is{" "} | ||
| <i>NOT</i> the expected Ethereum Mainnet address ( | ||
| <span className={bestPracticeTechnicalDetailsCodeStyles}> | ||
| 0x2222222222222222222222222222222222222222 | ||
| </span> | ||
| ). | ||
| </p> | ||
| <img | ||
| alt="1inch Wallet fails to resolve the name for ENSv2" | ||
| src={at1ProofImage.src} | ||
| className="w-auto h-full max-h-[325px] rounded-xl" | ||
| /> | ||
| </div> | ||
| ), | ||
| } as const satisfies AcceptanceTestBenchmark, | ||
| } as const satisfies AcceptanceTestBenchmarks; | ||
|
|
||
| export default ensv2ReadyResolution; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import React from "react"; | ||
|
|
||
| const Icon = ({ className, ...props }: React.SVGProps<SVGSVGElement>) => ( | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| width="181mm" | ||
| height="181mm" | ||
| version="1.1" | ||
| viewBox="0 0 513 513" | ||
| className={className} | ||
| {...props} | ||
| > | ||
| <path d="M512.8,0H0v512.8h512.8V0Z" /> | ||
| <path | ||
| d="M169.7,383.7h172.9v-36.7h-63.8s0-218.7,0-218.7h-37.8c-1.5,30.6-10.3,38.3-52.1,38.3h-19.2v34.6h63.8v145.8h-63.8v36.7ZM360.7,201.2v-72.9h-36.7v72.9h36.7ZM425.1,201.2v-72.9h-36.7v72.9h36.7Z" | ||
| fill="#fff" | ||
| /> | ||
| </svg> | ||
| ); | ||
|
|
||
| export default Icon; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md | ||
| // for additional advice on adding and modifying apps | ||
|
|
||
| import OneInchProject from "data/projects/1inch"; | ||
|
|
||
| import { defineApp } from "../registry.ts"; | ||
| import { type App, AppTypes } from "../types.ts"; | ||
| import OneInchIcon from "./icon.tsx"; | ||
|
|
||
| const OneInchWallet: App = { | ||
| id: "1inch-wallet", | ||
| appSlug: "1inch-wallet", | ||
| type: AppTypes.Wallet, | ||
| project: OneInchProject, | ||
| name: "1inch Wallet", | ||
| description: | ||
| "Self-custodial wallet for swapping, sending, and managing digital assets across Solana and EVM chains, with built-in access to 1inch DeFi trading.", | ||
| socials: { | ||
| website: new URL("https://1inch.com/wallet"), | ||
| twitter: new URL("https://x.com/1inch"), | ||
| }, | ||
| icon: OneInchIcon, | ||
| // TODO: Add OG images | ||
| }; | ||
|
|
||
| defineApp(OneInchWallet); | ||
|
|
||
| export default OneInchWallet; |
29 changes: 29 additions & 0 deletions
29
ensawards.org/data/apps/bitget-wallet/benchmarks/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md | ||
| // for additional advice on adding and modifying app benchmarks | ||
|
|
||
| import BitgetWallet from "data/apps/bitget-wallet"; | ||
| import { defineAppBenchmarks } from "data/benchmarks/registry"; | ||
| import type { BestPracticeBenchmarks } from "data/ens-best-practices/types"; | ||
|
|
||
| import depositAddresses from "./resolution/deposit-addresses"; | ||
| import ensv2ReadyResolution from "./resolution/ensv2-ready-resolution"; | ||
|
|
||
| const benchmarks = { | ||
| "ensv2-ready-resolution": ensv2ReadyResolution, | ||
| "deposit-addresses": depositAddresses, | ||
|
|
||
| // TODO: `Contract Naming` category is temporarily hidden due to unfit content, | ||
| // and so are all benchmarks belonging to it. | ||
| // We aim to fix it as soon as we have the capacity. | ||
| // See: https://github.com/namehash/ensawards/issues/222 | ||
| "display-named-smart-contracts-mainnet": { | ||
| "mainnet-interactions-display-named-smart-contracts": undefined, | ||
| }, | ||
| "display-named-smart-contracts-l2-chains": { | ||
| "l2-chain-interactions-display-named-smart-contracts": undefined, | ||
| }, | ||
| } as const satisfies BestPracticeBenchmarks; | ||
|
|
||
| defineAppBenchmarks(BitgetWallet, benchmarks); | ||
|
|
||
| export default benchmarks; |
Binary file added
BIN
+15.2 KB
...ds.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+15.1 KB
...ds.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11.9 KB
...ds.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11.4 KB
...ds.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+16.3 KB
...ds.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-5.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+12.4 KB
...ds.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-6.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+13.4 KB
...ds.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-7.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.