feat: Add new apps - tranche 4 - batch 4 - wallets#255
Merged
Conversation
…rk/feat/add-wallets-t4-b4
|
Too many files changed for review. ( Bypass the limit by tagging |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a new tranche of wallet apps to the ENS Awards data layer, including their associated projects (where needed) and resolution best-practice benchmark results so they appear in the site’s app/project registry and scoring views.
Changes:
- Added 9 new
walletapps (Uniswap Wallet, 1inch Wallet, Bitget Wallet, MyEtherWallet, Enkrypt, Gem Wallet, imToken, SafePal, TokenPocket). - Added new projects/ProjectIds for MEW, Gem, imToken, SafePal, and TokenPocket.
- Added resolution-category benchmarks (
ensv2-ready-resolution,deposit-addresses) and benchmark registry entries for each new app.
Reviewed changes
Copilot reviewed 56 out of 110 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ensawards.org/data/projects/types.ts | Adds new ProjectIds entries for newly introduced projects. |
| ensawards.org/data/projects/tokenpocket/index.ts | Defines the TokenPocket project metadata. |
| ensawards.org/data/projects/tokenpocket/icon.tsx | Adds TokenPocket project icon. |
| ensawards.org/data/projects/safepal/index.ts | Defines the SafePal project metadata. |
| ensawards.org/data/projects/safepal/icon.tsx | Adds SafePal project icon. |
| ensawards.org/data/projects/mew/index.ts | Defines the MEW project metadata. |
| ensawards.org/data/projects/mew/icon.tsx | Adds MEW project icon. |
| ensawards.org/data/projects/imtoken/index.ts | Defines the imToken project metadata. |
| ensawards.org/data/projects/imtoken/icon.tsx | Adds imToken project icon. |
| ensawards.org/data/projects/gem/index.ts | Defines the Gem project metadata. |
| ensawards.org/data/projects/gem/icon.tsx | Adds Gem project icon. |
| ensawards.org/data/apps/uniswap-wallet/index.ts | Adds Uniswap Wallet app definition. |
| ensawards.org/data/apps/uniswap-wallet/icon.tsx | Adds Uniswap Wallet app icon. |
| ensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds Uniswap Wallet ENSv2-ready-resolution benchmark. |
| ensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/deposit-addresses/index.tsx | Adds Uniswap Wallet deposit-addresses benchmark. |
| ensawards.org/data/apps/uniswap-wallet/benchmarks/index.tsx | Registers Uniswap Wallet benchmarks. |
| ensawards.org/data/apps/tokenpocket-wallet/index.ts | Adds TokenPocket Wallet app definition. |
| ensawards.org/data/apps/tokenpocket-wallet/icon.tsx | Adds TokenPocket Wallet app icon. |
| ensawards.org/data/apps/tokenpocket-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds TokenPocket Wallet ENSv2-ready-resolution benchmark. |
| ensawards.org/data/apps/tokenpocket-wallet/benchmarks/resolution/deposit-addresses/index.tsx | Adds TokenPocket Wallet deposit-addresses benchmark. |
| ensawards.org/data/apps/tokenpocket-wallet/benchmarks/index.tsx | Registers TokenPocket Wallet benchmarks. |
| ensawards.org/data/apps/safepal-wallet/index.ts | Adds SafePal Wallet app definition. |
| ensawards.org/data/apps/safepal-wallet/icon.tsx | Adds SafePal Wallet app icon. |
| ensawards.org/data/apps/safepal-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds SafePal Wallet ENSv2-ready-resolution benchmark. |
| ensawards.org/data/apps/safepal-wallet/benchmarks/resolution/deposit-addresses/index.tsx | Adds SafePal Wallet deposit-addresses benchmark. |
| ensawards.org/data/apps/safepal-wallet/benchmarks/index.tsx | Registers SafePal Wallet benchmarks. |
| ensawards.org/data/apps/mew-wallet/index.ts | Adds MyEtherWallet app definition. |
| ensawards.org/data/apps/mew-wallet/icon.tsx | Adds MyEtherWallet app icon. |
| ensawards.org/data/apps/mew-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds MyEtherWallet ENSv2-ready-resolution benchmark. |
| ensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/index.tsx | Adds MyEtherWallet deposit-addresses benchmark. |
| ensawards.org/data/apps/mew-wallet/benchmarks/index.tsx | Registers MyEtherWallet benchmarks. |
| ensawards.org/data/apps/imtoken-wallet/index.ts | Adds imToken Wallet app definition. |
| ensawards.org/data/apps/imtoken-wallet/icon.tsx | Adds imToken Wallet app icon. |
| ensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds imToken Wallet ENSv2-ready-resolution benchmark. |
| ensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/deposit-addresses/index.tsx | Adds imToken Wallet deposit-addresses benchmark. |
| ensawards.org/data/apps/imtoken-wallet/benchmarks/index.tsx | Registers imToken Wallet benchmarks. |
| ensawards.org/data/apps/gem-wallet/index.ts | Adds Gem Wallet app definition. |
| ensawards.org/data/apps/gem-wallet/icon.tsx | Adds Gem Wallet app icon. |
| ensawards.org/data/apps/gem-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds Gem Wallet ENSv2-ready-resolution benchmark. |
| ensawards.org/data/apps/gem-wallet/benchmarks/resolution/deposit-addresses/index.tsx | Adds Gem Wallet deposit-addresses benchmark. |
| ensawards.org/data/apps/gem-wallet/benchmarks/index.tsx | Registers Gem Wallet benchmarks. |
| ensawards.org/data/apps/enkrypt-wallet/index.ts | Adds Enkrypt Wallet app definition (under MEW project). |
| ensawards.org/data/apps/enkrypt-wallet/icon.tsx | Adds Enkrypt Wallet app icon. |
| ensawards.org/data/apps/enkrypt-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds Enkrypt Wallet ENSv2-ready-resolution benchmark. |
| ensawards.org/data/apps/enkrypt-wallet/benchmarks/resolution/deposit-addresses/index.tsx | Adds Enkrypt Wallet deposit-addresses benchmark. |
| ensawards.org/data/apps/enkrypt-wallet/benchmarks/index.tsx | Registers Enkrypt Wallet benchmarks. |
| ensawards.org/data/apps/bitget-wallet/index.ts | Adds Bitget Wallet app definition. |
| ensawards.org/data/apps/bitget-wallet/icon.tsx | Adds Bitget Wallet app icon. |
| ensawards.org/data/apps/bitget-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds Bitget Wallet ENSv2-ready-resolution benchmark. |
| ensawards.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/index.tsx | Adds Bitget Wallet deposit-addresses benchmark. |
| ensawards.org/data/apps/bitget-wallet/benchmarks/index.tsx | Registers Bitget Wallet benchmarks. |
| ensawards.org/data/apps/1inch-wallet/index.ts | Adds 1inch Wallet app definition. |
| ensawards.org/data/apps/1inch-wallet/icon.tsx | Adds 1inch Wallet app icon. |
| ensawards.org/data/apps/1inch-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds 1inch Wallet ENSv2-ready-resolution benchmark. |
| ensawards.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/index.tsx | Adds 1inch Wallet deposit-addresses benchmark. |
| ensawards.org/data/apps/1inch-wallet/benchmarks/index.tsx | Registers 1inch Wallet benchmarks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughWalkthroughThis PR adds new wallet app registrations, shared project entries, SVG icon components, benchmark registries, and acceptance-test benchmark datasets for deposit-addresses and ENSv2-ready-resolution across multiple wallets. ChangesNew wallet apps, projects, icons, and benchmarks
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ensawards.org/data/apps/1inch-wallet/icon.tsx`:
- Around line 6-9: The SVG in the 1inch wallet icon component uses physical-unit
width and height values that can force an unintended large render size. Update
the icon definition in the SVG component to normalize the dimensions, either by
switching the width and height in the icon markup to unitless/px-friendly values
or by removing the fixed size attributes and relying on the existing viewBox.
Keep the change localized to the icon component so props passed through the
component can still override sizing when needed.
In
`@ensawards.org/data/apps/bitget-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx`:
- Around line 1-3: The imports in the benchmark module are split for the same
source even though `AcceptanceTestBenchmarks` and `BenchmarkResults` both come
from `data/benchmarks/types`. Update the top-level imports in `index.tsx` to use
a single import statement for that module, keeping the type-only specifier
alongside the value import, and follow the same pattern used in
`deposit-addresses/index.tsx`.
In `@ensawards.org/data/apps/enkrypt-wallet/icon.tsx`:
- Line 15: The embedded SVG image in the icon component is missing an accessible
name, so update the image element in the icon rendering logic to provide a
screen-reader label, using the existing icon-related JSX in icon.tsx. Add an
appropriate accessible label attribute or mark it decorative if it is
non-informative, and keep the change localized to the icon image element
referenced by icon.src.
In
`@ensawards.org/data/apps/gem-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx`:
- Around line 4-6: The imports at the top of the benchmark file are split
unnecessarily for the same module: `AcceptanceTestBenchmarks` from
`data/benchmarks/types` is a type-only import while `BenchmarkResults` is a
value import. Update the import section to use a single combined import
statement for that module, keeping the type and non-type symbols together, and
leave the separate `AcceptanceTestBenchmark` import only if it comes from a
different module.
In
`@ensawards.org/data/apps/mew-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx`:
- Around line 35-39: The proof image alt text in the ENSv2-ready resolution
benchmark is referring to the wrong wallet. Update the <img> element in the
benchmark component for MyEtherWallet so the alt text matches MEW/MyEtherWallet
instead of “1inch Wallet,” keeping the wording aligned with the specific
benchmark shown in this file.
In
`@ensawards.org/data/apps/tokenpocket-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsx`:
- Around line 4-6: The imports in this module are split between a type-only
import and a value import for the same source, which should be combined. Update
the import section in the tokenpocket-wallet ENSv2 resolution benchmark file so
that AcceptanceTestBenchmarks and BenchmarkResults from data/benchmarks/types
are brought in together in one import statement, while keeping
AcceptanceTestBenchmark as a separate type import only if needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0036c8d1-19d8-46dd-bea8-de453294ccdb
⛔ Files ignored due to path filters (54)
ensawards.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-2.gifis excluded by!**/*.gifensawards.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-3.gifis excluded by!**/*.gifensawards.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-4.gifis excluded by!**/*.gifensawards.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/1inch-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/enkrypt-wallet/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/enkrypt-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/enkrypt-wallet/icon.pngis excluded by!**/*.pngensawards.org/data/apps/gem-wallet/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/gem-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/gem-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/gem-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/gem-wallet/benchmarks/resolution/deposit-addresses/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/gem-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/gem-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/gem-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/deposit-addresses/at-7.gifis excluded by!**/*.gifensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/mew-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/safepal-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/safepal-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/tokenpocket-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/tokenpocket-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/deposit-addresses/at-4.gifis excluded by!**/*.gifensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/deposit-addresses/at-6.gifis excluded by!**/*.gifensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/deposit-addresses/at-7.gifis excluded by!**/*.gifensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.png
📒 Files selected for processing (56)
ensawards.org/data/apps/1inch-wallet/benchmarks/index.tsxensawards.org/data/apps/1inch-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/1inch-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/1inch-wallet/icon.tsxensawards.org/data/apps/1inch-wallet/index.tsensawards.org/data/apps/bitget-wallet/benchmarks/index.tsxensawards.org/data/apps/bitget-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/bitget-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/bitget-wallet/icon.tsxensawards.org/data/apps/bitget-wallet/index.tsensawards.org/data/apps/enkrypt-wallet/benchmarks/index.tsxensawards.org/data/apps/enkrypt-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/enkrypt-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/enkrypt-wallet/icon.tsxensawards.org/data/apps/enkrypt-wallet/index.tsensawards.org/data/apps/gem-wallet/benchmarks/index.tsxensawards.org/data/apps/gem-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/gem-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/gem-wallet/icon.tsxensawards.org/data/apps/gem-wallet/index.tsensawards.org/data/apps/imtoken-wallet/benchmarks/index.tsxensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/imtoken-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/imtoken-wallet/icon.tsxensawards.org/data/apps/imtoken-wallet/index.tsensawards.org/data/apps/mew-wallet/benchmarks/index.tsxensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/mew-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/mew-wallet/icon.tsxensawards.org/data/apps/mew-wallet/index.tsensawards.org/data/apps/safepal-wallet/benchmarks/index.tsxensawards.org/data/apps/safepal-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/safepal-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/safepal-wallet/icon.tsxensawards.org/data/apps/safepal-wallet/index.tsensawards.org/data/apps/tokenpocket-wallet/benchmarks/index.tsxensawards.org/data/apps/tokenpocket-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/tokenpocket-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/tokenpocket-wallet/icon.tsxensawards.org/data/apps/tokenpocket-wallet/index.tsensawards.org/data/apps/uniswap-wallet/benchmarks/index.tsxensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/uniswap-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/uniswap-wallet/icon.tsxensawards.org/data/apps/uniswap-wallet/index.tsensawards.org/data/projects/gem/icon.tsxensawards.org/data/projects/gem/index.tsensawards.org/data/projects/imtoken/icon.tsxensawards.org/data/projects/imtoken/index.tsensawards.org/data/projects/mew/icon.tsxensawards.org/data/projects/mew/index.tsensawards.org/data/projects/safepal/icon.tsxensawards.org/data/projects/safepal/index.tsensawards.org/data/projects/tokenpocket/icon.tsxensawards.org/data/projects/tokenpocket/index.tsensawards.org/data/projects/types.ts
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| className={cn("p-1 bg-white rounded-md", className)} | ||
| {...props} | ||
| > | ||
| <image href={icon.src} aria-label="false" width="24" height="24" /> |
Contributor
There was a problem hiding this comment.
aria-label="false" on the <image> element sets the accessible name to the literal string "false", which screen readers announce misleadingly.
| className={cn("p-1 bg-white rounded-md", className)} | ||
| {...props} | ||
| > | ||
| <image href={icon.src} aria-label="false" width="24" height="24" /> |
| @@ -0,0 +1,42 @@ | |||
| import type { AcceptanceTestBenchmark } from "data/acceptance-tests/types"; | |||
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
ensawards.org/data/apps/enkrypt-wallet/icon.tsx (1)
15-15: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
aria-label="false"is still unresolved.This was already flagged twice in prior review rounds (by coderabbitai and Vercel bots): setting
aria-label="false"gives the<image>an accessible name of the literal string "false", which screen readers will announce — worse than omitting it. This is still present in the current code. The same pattern also appears inmew-wallet/icon.tsxper the code graph and should be fixed consistently.♿ Proposed fix
- <image href={icon.src} aria-label="false" width="24" height="24" /> + <image href={icon.src} aria-label="Enkrypt" width="24" height="24" />Or, if the icon is purely decorative:
- <image href={icon.src} aria-label="false" width="24" height="24" /> + <image href={icon.src} aria-hidden="true" width="24" height="24" />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ensawards.org/data/apps/enkrypt-wallet/icon.tsx` at line 15, The accessible-name issue on the JSX <image> element is still unresolved because aria-label is set to the literal string "false", which should be removed or replaced with the correct accessibility treatment. Update the icon rendering in this component so decorative icons are hidden from assistive tech (or given a meaningful label only when truly needed), and apply the same fix consistently in the matching wallet icon component referenced by the code graph.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ensawards.org/data/apps/mewweb-wallet/index.ts`:
- Line 10: Rename the exported app constant in MyEtherWalletWeb’s module so it
ends with the Wallet suffix, and update the default export plus all
import/re-export sites that reference the old name. Keep the rename consistent
with the existing wallet app naming pattern used by symbols like RainbowWallet.
---
Duplicate comments:
In `@ensawards.org/data/apps/enkrypt-wallet/icon.tsx`:
- Line 15: The accessible-name issue on the JSX <image> element is still
unresolved because aria-label is set to the literal string "false", which should
be removed or replaced with the correct accessibility treatment. Update the icon
rendering in this component so decorative icons are hidden from assistive tech
(or given a meaningful label only when truly needed), and apply the same fix
consistently in the matching wallet icon component referenced by the code graph.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d119953b-b60d-45d3-8973-2a2036ea27fd
⛔ Files ignored due to path filters (10)
ensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/mew-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.png
📒 Files selected for processing (11)
ensawards.org/data/apps/1inch-wallet/icon.tsxensawards.org/data/apps/enkrypt-wallet/icon.tsxensawards.org/data/apps/mew-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/mew-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/mew-wallet/icon.tsxensawards.org/data/apps/mew-wallet/index.tsensawards.org/data/apps/mewweb-wallet/benchmarks/index.tsxensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/mewweb-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/mewweb-wallet/icon.tsxensawards.org/data/apps/mewweb-wallet/index.ts
lightwalker-eth
approved these changes
Jul 3, 2026
lightwalker-eth
left a comment
lightwalker-eth
left a comment
Member
There was a problem hiding this comment.
@Y3drk Great updates! Nice work 🫡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lite PR → Add new apps - tranche 4 - batch 4 - wallets
Summary
wallet(listed below)resolutionbest practice category.NOTE: I am unsure about the classification of the apps in the MEW project, more info below)UPDATE:
MyEtherWallet now has separate entries (and benchmarks) for its web app and its mobile app:
MyEtherWallet WebMyEtherWalletnameWhy
Testing
typecheck,lint, andtestcommands locally to ensure that the migration didn't break anything, and later confirmed that in our CI workflowNotes for reviewer
The MEW project has 3 apps:
The 2nd app is without any doubt a wallet and is added as such, but when it comes to the other two, I'm not certain how to proceed.
sendflow available, but one could argue that the code name (portfolio manager) as well as other features (like trade) or just an ability to connect another wallet to it could make it aDeFiapp (see the screenshot below). Appreciate advice on thatPre-Review Checklist (Blocking)