feat: Add new apps - tranche 4 - exchanges batch 2#251
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds tranche 4 / exchanges batch 2 data entries to the ENS Awards dataset by introducing new exchange apps (and their backing project records) along with resolution-category benchmark writeups so they can be rendered and scored in the app/benchmarks registry.
Changes:
- Added 6 new
Projectdefinitions (MEXC, Toobit, LBank, BitMart, CoinW, WEEX) and extendedProjectIds. - Added 6 new
ExchangeAppdefinitions wired to those projects, including icons and socials. - Added per-app resolution benchmarks (
ensv2-ready-resolution,deposit-addresses) and registered them viadefineAppBenchmarks.
Reviewed changes
Copilot reviewed 43 out of 59 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ensawards.org/data/projects/types.ts | Adds new ProjectIds entries for the tranche. |
| ensawards.org/data/projects/weex/index.ts | Defines WEEX project metadata and registers it. |
| ensawards.org/data/projects/weex/icon.tsx | Adds WEEX project icon component. |
| ensawards.org/data/projects/toobit/index.ts | Defines Toobit project metadata and registers it. |
| ensawards.org/data/projects/toobit/icon.tsx | Adds Toobit project icon component (PNG-in-SVG). |
| ensawards.org/data/projects/mexc/index.ts | Defines MEXC project metadata and registers it. |
| ensawards.org/data/projects/mexc/icon.tsx | Adds MEXC project icon component. |
| ensawards.org/data/projects/lbank/index.ts | Defines LBank project metadata and registers it. |
| ensawards.org/data/projects/lbank/icon.tsx | Adds LBank project icon component. |
| ensawards.org/data/projects/coinw/index.ts | Defines CoinW project metadata and registers it. |
| ensawards.org/data/projects/coinw/icon.tsx | Adds CoinW project icon component. |
| ensawards.org/data/projects/bitmart/index.ts | Defines BitMart project metadata and registers it. |
| ensawards.org/data/projects/bitmart/icon.tsx | Adds BitMart project icon component (PNG-in-SVG). |
| ensawards.org/data/apps/weex-exchange/index.ts | Defines WEEX exchange app and registers it. |
| ensawards.org/data/apps/weex-exchange/icon.tsx | Adds WEEX app icon component. |
| ensawards.org/data/apps/weex-exchange/benchmarks/index.tsx | Registers WEEX exchange resolution benchmarks. |
| ensawards.org/data/apps/weex-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds WEEX ensv2-ready-resolution benchmark notes/results. |
| ensawards.org/data/apps/weex-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds WEEX deposit-addresses benchmark notes/results. |
| ensawards.org/data/apps/toobit-exchange/index.ts | Defines Toobit exchange app and registers it. |
| ensawards.org/data/apps/toobit-exchange/icon.tsx | Adds Toobit app icon component (PNG-in-SVG). |
| ensawards.org/data/apps/toobit-exchange/benchmarks/index.tsx | Registers Toobit exchange resolution benchmarks. |
| ensawards.org/data/apps/toobit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds Toobit ensv2-ready-resolution benchmark notes/results. |
| ensawards.org/data/apps/toobit-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds Toobit deposit-addresses benchmark notes/results. |
| ensawards.org/data/apps/mexc-exchange/index.ts | Defines MEXC exchange app and registers it. |
| ensawards.org/data/apps/mexc-exchange/icon.tsx | Adds MEXC app icon component. |
| ensawards.org/data/apps/mexc-exchange/benchmarks/index.tsx | Registers MEXC exchange resolution benchmarks. |
| ensawards.org/data/apps/mexc-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds MEXC ensv2-ready-resolution benchmark notes/results. |
| ensawards.org/data/apps/mexc-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds MEXC deposit-addresses benchmark notes/results. |
| ensawards.org/data/apps/lbank-exchange/index.ts | Defines LBank exchange app and registers it. |
| ensawards.org/data/apps/lbank-exchange/icon.tsx | Adds LBank app icon component. |
| ensawards.org/data/apps/lbank-exchange/benchmarks/index.tsx | Registers LBank exchange resolution benchmarks. |
| ensawards.org/data/apps/lbank-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds LBank ensv2-ready-resolution benchmark notes/results. |
| ensawards.org/data/apps/lbank-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds LBank deposit-addresses benchmark notes/results. |
| ensawards.org/data/apps/coinw-exchange/index.ts | Defines CoinW exchange app and registers it. |
| ensawards.org/data/apps/coinw-exchange/icon.tsx | Adds CoinW app icon component. |
| ensawards.org/data/apps/coinw-exchange/benchmarks/index.tsx | Registers CoinW exchange resolution benchmarks. |
| ensawards.org/data/apps/coinw-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds CoinW ensv2-ready-resolution benchmark notes/results. |
| ensawards.org/data/apps/coinw-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds CoinW deposit-addresses benchmark notes/results. |
| ensawards.org/data/apps/bitmart-exchange/index.ts | Defines BitMart exchange app and registers it. |
| ensawards.org/data/apps/bitmart-exchange/icon.tsx | Adds BitMart app icon component (PNG-in-SVG). |
| ensawards.org/data/apps/bitmart-exchange/benchmarks/index.tsx | Registers BitMart exchange resolution benchmarks. |
| ensawards.org/data/apps/bitmart-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds BitMart ensv2-ready-resolution benchmark notes/results. |
| ensawards.org/data/apps/bitmart-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds BitMart deposit-addresses benchmark notes/results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR registers six new exchange apps (BitMart, CoinW, LBank, MEXC, Toobit, WEEX) and their linked project entries. Each addition includes an icon component, app/project definitions registered via ChangesNew Exchange Apps, Projects, and Benchmarks
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds six new exchange apps (MEXC, Toobit, LBank, BitMart, CoinW, WEEX) to the ENS Awards data registry, each including a project definition, app definition, icon component, and benchmarks for the
Confidence Score: 5/5Safe to merge — the change is purely additive data registration with no modifications to shared logic. All six exchanges follow the established registration pattern exactly: defineProject/defineApp calls are present, ProjectIds are correctly referenced, and all benchmark results are logically consistent (at01 Fail, at02–at08 NotApplicable). No shared types or runtime paths are modified beyond the additive ProjectIds constants. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
PT[types.ts\nProjectIds] -->|new entries| P1[projects/mexc]
PT -->|new entries| P2[projects/toobit]
PT -->|new entries| P3[projects/lbank]
PT -->|new entries| P4[projects/bitmart]
PT -->|new entries| P5[projects/coinw]
PT -->|new entries| P6[projects/weex]
P1 --> A1[apps/mexc-exchange]
P2 --> A2[apps/toobit-exchange]
P3 --> A3[apps/lbank-exchange]
P4 --> A4[apps/bitmart-exchange]
P5 --> A5[apps/coinw-exchange]
P6 --> A6[apps/weex-exchange]
A1 --> B1[benchmarks\ndeposit-addresses\nat01=Fail, at02-at08=N/A]
A1 --> B2[benchmarks\nensv2-ready-resolution\nN/A]
A2 --> B1
A2 --> B2
A3 --> B1
A3 --> B2
A4 --> B1
A4 --> B2
A5 --> B1
A5 --> B2
A6 --> B1
A6 --> B2
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
PT[types.ts\nProjectIds] -->|new entries| P1[projects/mexc]
PT -->|new entries| P2[projects/toobit]
PT -->|new entries| P3[projects/lbank]
PT -->|new entries| P4[projects/bitmart]
PT -->|new entries| P5[projects/coinw]
PT -->|new entries| P6[projects/weex]
P1 --> A1[apps/mexc-exchange]
P2 --> A2[apps/toobit-exchange]
P3 --> A3[apps/lbank-exchange]
P4 --> A4[apps/bitmart-exchange]
P5 --> A5[apps/coinw-exchange]
P6 --> A6[apps/weex-exchange]
A1 --> B1[benchmarks\ndeposit-addresses\nat01=Fail, at02-at08=N/A]
A1 --> B2[benchmarks\nensv2-ready-resolution\nN/A]
A2 --> B1
A2 --> B2
A3 --> B1
A3 --> B2
A4 --> B1
A4 --> B2
A5 --> B1
A5 --> B2
A6 --> B1
A6 --> B2
Reviews (3): Last reviewed commit: "Apply AI agents' suggestions, pt.1" | Re-trigger Greptile |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ensawards.org/data/apps/bitmart-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx`:
- Around line 4-6: The imports in this module are split unnecessarily for the
same source, with AcceptanceTestBenchmarks and BenchmarkResults coming from
data/benchmarks/types in separate statements. Update the top-level imports in
index.tsx to follow the repository pattern by combining the type-only and value
import from that module into a single import statement, using the same style as
the sibling deposit-addresses/index.tsx and keeping separate imports only when
there are 3 or more type imports.
In
`@ensawards.org/data/apps/coinw-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx`:
- Around line 5-6: The imports in this module are split across two statements
for the same source, which violates the project convention for mixed type/value
imports. Update the import section in index.tsx so AcceptanceTestBenchmarks and
BenchmarkResults from data/benchmarks/types are combined into a single import
statement, matching the pattern used in the sibling deposit-addresses/index.tsx
file.
In
`@ensawards.org/data/apps/toobit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx`:
- Around line 5-6: The imports in this benchmark module split
`AcceptanceTestBenchmarks` and `BenchmarkResults` from the same
`data/benchmarks/types` module into separate statements. Update the top-level
imports in `index.tsx` to merge them into one import statement, keeping the
type-only specifier and the value import together unless there are 3 or more
type imports.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: b07c1762-aa5e-4652-a2f9-d797dbccfb43
⛔ Files ignored due to path filters (16)
ensawards.org/data/apps/bitmart-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bitmart-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bitmart-exchange/icon.pngis excluded by!**/*.pngensawards.org/data/apps/coinw-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/coinw-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/lbank-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/lbank-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/mexc-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/mexc-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/toobit-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/toobit-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/toobit-exchange/icon.pngis excluded by!**/*.pngensawards.org/data/apps/weex-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/weex-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/projects/bitmart/icon.pngis excluded by!**/*.pngensawards.org/data/projects/toobit/icon.pngis excluded by!**/*.png
📒 Files selected for processing (43)
ensawards.org/data/apps/bitmart-exchange/benchmarks/index.tsxensawards.org/data/apps/bitmart-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/bitmart-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/bitmart-exchange/icon.tsxensawards.org/data/apps/bitmart-exchange/index.tsensawards.org/data/apps/coinw-exchange/benchmarks/index.tsxensawards.org/data/apps/coinw-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/coinw-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/coinw-exchange/icon.tsxensawards.org/data/apps/coinw-exchange/index.tsensawards.org/data/apps/lbank-exchange/benchmarks/index.tsxensawards.org/data/apps/lbank-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/lbank-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/lbank-exchange/icon.tsxensawards.org/data/apps/lbank-exchange/index.tsensawards.org/data/apps/mexc-exchange/benchmarks/index.tsxensawards.org/data/apps/mexc-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/mexc-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/mexc-exchange/icon.tsxensawards.org/data/apps/mexc-exchange/index.tsensawards.org/data/apps/toobit-exchange/benchmarks/index.tsxensawards.org/data/apps/toobit-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/toobit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/toobit-exchange/icon.tsxensawards.org/data/apps/toobit-exchange/index.tsensawards.org/data/apps/weex-exchange/benchmarks/index.tsxensawards.org/data/apps/weex-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/weex-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/weex-exchange/icon.tsxensawards.org/data/apps/weex-exchange/index.tsensawards.org/data/projects/bitmart/icon.tsxensawards.org/data/projects/bitmart/index.tsensawards.org/data/projects/coinw/icon.tsxensawards.org/data/projects/coinw/index.tsensawards.org/data/projects/lbank/icon.tsxensawards.org/data/projects/lbank/index.tsensawards.org/data/projects/mexc/icon.tsxensawards.org/data/projects/mexc/index.tsensawards.org/data/projects/toobit/icon.tsxensawards.org/data/projects/toobit/index.tsensawards.org/data/projects/types.tsensawards.org/data/projects/weex/icon.tsxensawards.org/data/projects/weex/index.ts
Lite PR → Add new apps - tranche 4 - exchanges batch 2
Summary
exchange(listed below)resolutionbest practice category.Why
Testing
typecheck,lint, andtestcommands locally to ensure that the migration didn't break anything, and later confirmed that in our CI workflowPre-Review Checklist (Blocking)