Skip to content

feat: Add new apps - tranche 4 - exchanges batch 3#253

Merged
Y3drk merged 5 commits into
mainfrom
y3drk/feat/add-exchanges-t4-b3
Jul 2, 2026
Merged

feat: Add new apps - tranche 4 - exchanges batch 3#253
Y3drk merged 5 commits into
mainfrom
y3drk/feat/add-exchanges-t4-b3

Conversation

@Y3drk

@Y3drk Y3drk commented Jul 2, 2026

Copy link
Copy Markdown
Member

Lite PR → Add new apps - tranche 4 - exchanges batch 3

Summary

  • Added new apps of type exchange (listed below)
  • Benchmarked them on all acceptance tests from the resolution best practice category.
  • Added in this PR:
    • Ourbit
    • XT.COM
    • Bitunix
    • WhiteBIT (NOTE: Couldn't benchmark the SOL & BTC-related ATs due to insufficient funds, I've added a general issue to the repo to track and revisit all such cases laterTrack and retry pending benchmarks #252)

Why


Testing

  • Ran typecheck, lint, and test commands locally to ensure that the migration didn't break anything, and later confirmed that in our CI workflow
  • Verified that the UI didn't break after introducing changes using a local and Vercel previews.

Pre-Review Checklist (Blocking)

  • This PR does not introduce significant changes and is low-risk to review quickly.

@Y3drk Y3drk self-assigned this Jul 2, 2026
@Y3drk Y3drk requested a review from a team as a code owner July 2, 2026 07:22
Copilot AI review requested due to automatic review settings July 2, 2026 07:22
@Y3drk Y3drk added the ensawards ENSAwards related label Jul 2, 2026
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ensawards.org Ready Ready Preview, Comment Jul 2, 2026 7:38am

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Y3drk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c7f2356b-5dc1-48d2-9bc5-d3cafb7f5022

📥 Commits

Reviewing files that changed from the base of the PR and between 9ab5959 and d3be0f7.

📒 Files selected for processing (2)
  • ensawards.org/data/apps/xtcom-exchange/icon.tsx
  • ensawards.org/data/projects/xtcom/icon.tsx
📝 Walkthrough

Walkthrough

Adds four new exchange apps (Bitunix, Ourbit, WhiteBIT, XT.COM) and their associated projects. Each includes a project definition with icon and socials, an app definition with icon, and benchmark modules for deposit-addresses and ensv2-ready-resolution resolution tests. Extends ProjectIds with four new identifiers.

Changes

Bitunix Exchange and Project

Layer / File(s) Summary
Bitunix project and icon
ensawards.org/data/projects/bitunix/index.ts, ensawards.org/data/projects/bitunix/icon.tsx
Defines BitunixProject with metadata and socials, registers via defineProject, and adds the project icon component.
Bitunix exchange app and icon
ensawards.org/data/apps/bitunix-exchange/index.ts, ensawards.org/data/apps/bitunix-exchange/icon.tsx
Defines BitunixExchange app tied to BitunixProject, registers via defineApp, and adds the app icon component.
Bitunix benchmarks
ensawards.org/data/apps/bitunix-exchange/benchmarks/index.tsx, .../resolution/deposit-addresses/index.tsx, .../resolution/ensv2-ready-resolution/index.tsx
Adds depositAddresses (at01–at08) and ensv2ReadyResolution benchmark definitions and registers them via defineAppBenchmarks.

Ourbit Exchange and Project

Layer / File(s) Summary
Ourbit project and icon
ensawards.org/data/projects/ourbit/index.ts, ensawards.org/data/projects/ourbit/icon.tsx
Defines OurbitProject metadata/socials and icon component.
Ourbit exchange app and icon
ensawards.org/data/apps/ourbit-exchange/index.ts, ensawards.org/data/apps/ourbit-exchange/icon.tsx
Defines OurbitExchange app and icon component.
Ourbit benchmarks
ensawards.org/data/apps/ourbit-exchange/benchmarks/index.tsx, .../resolution/deposit-addresses/index.tsx, .../resolution/ensv2-ready-resolution/index.tsx
Adds depositAddresses and ensv2ReadyResolution benchmark definitions and registers them.

WhiteBIT Exchange and Project

Layer / File(s) Summary
WhiteBIT project and icon
ensawards.org/data/projects/whitebit/index.ts, ensawards.org/data/projects/whitebit/icon.tsx
Defines WhiteBITProject metadata/socials and icon component.
WhiteBIT exchange app and icon
ensawards.org/data/apps/whitebit-exchange/index.ts, ensawards.org/data/apps/whitebit-exchange/icon.tsx
Defines WhiteBITExchange app and icon component.
WhiteBIT benchmarks
ensawards.org/data/apps/whitebit-exchange/benchmarks/index.tsx, .../resolution/deposit-addresses/index.tsx, .../resolution/ensv2-ready-resolution/index.tsx
Adds depositAddresses (Pass/Fail/undefined/NotApplicable across AT01–AT08) and ensv2ReadyResolution (Fail) benchmark definitions and registers them.

XT.COM Exchange and Project

Layer / File(s) Summary
XT.COM project and icon
ensawards.org/data/projects/xtcom/index.ts, ensawards.org/data/projects/xtcom/icon.tsx
Defines XTcomProject metadata/socials and icon component.
XT.COM exchange app and icon
ensawards.org/data/apps/xtcom-exchange/index.ts, ensawards.org/data/apps/xtcom-exchange/icon.tsx
Defines XTcomExchange app and icon component.
XT.COM benchmarks
ensawards.org/data/apps/xtcom-exchange/benchmarks/index.tsx, .../resolution/deposit-addresses/index.tsx, .../resolution/ensv2-ready-resolution/index.tsx
Adds depositAddresses and ensv2ReadyResolution benchmark definitions and registers them.

Shared Types

Layer / File(s) Summary
ProjectIds extension
ensawards.org/data/projects/types.ts
Adds Bitunix, XTcom, WhiteBIT, Ourbit keys to ProjectIds, expanding ProjectId.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

Suggested labels: ensawards

Poem

Four new burrows dug in code so neat,
Bitunix, Ourbit, WhiteBIT, XT — a treat! 🐰
Icons drawn and benchmarks penned with care,
Deposit tests and ENSv2 flair,
Hop along, reviewer, the warren's complete!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates a new-app exchange batch, which matches the main change set.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description matches the changeset by listing the new exchange apps and their benchmark additions.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch y3drk/feat/add-exchanges-t4-b3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new tranche of exchange apps (plus their parent projects) to the ENSAwards data registry, along with resolution best-practice benchmark results and evidence assets so they appear in the app/project listings and benchmark dashboards.

Changes:

  • Added 4 new projects: Ourbit, XT.COM, Bitunix, WhiteBIT
  • Added 4 new exchange apps tied to those projects
  • Added resolution benchmark datasets (deposit-addresses + ENSv2-ready-resolution) for the new apps, including pending benchmarks represented as undefined where applicable

Reviewed changes

Copilot reviewed 29 out of 45 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ensawards.org/data/projects/xtcom/index.ts Registers the XT.COM project metadata in the projects registry
ensawards.org/data/projects/xtcom/icon.tsx Adds XT.COM project icon component (raster image wrapped in SVG)
ensawards.org/data/projects/whitebit/index.ts Registers the WhiteBIT project metadata in the projects registry
ensawards.org/data/projects/whitebit/icon.tsx Adds WhiteBIT project icon component (inline SVG path)
ensawards.org/data/projects/types.ts Extends ProjectIds with Bitunix / XTcom / WhiteBIT / Ourbit IDs
ensawards.org/data/projects/ourbit/index.ts Registers the Ourbit project metadata in the projects registry
ensawards.org/data/projects/ourbit/icon.tsx Adds Ourbit project icon component (inline SVG path)
ensawards.org/data/projects/bitunix/index.ts Registers the Bitunix project metadata in the projects registry
ensawards.org/data/projects/bitunix/icon.tsx Adds Bitunix project icon component (raster image wrapped in SVG)
ensawards.org/data/apps/xtcom-exchange/index.ts Registers the XT.COM exchange app tied to the XT.COM project
ensawards.org/data/apps/xtcom-exchange/icon.tsx Adds XT.COM exchange app icon component
ensawards.org/data/apps/xtcom-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx Adds XT.COM ENSv2-ready-resolution benchmark result + evidence
ensawards.org/data/apps/xtcom-exchange/benchmarks/resolution/deposit-addresses/index.tsx Adds XT.COM deposit-addresses benchmark results + evidence
ensawards.org/data/apps/xtcom-exchange/benchmarks/index.tsx Registers XT.COM benchmarks in the benchmarks registry
ensawards.org/data/apps/whitebit-exchange/index.ts Registers the WhiteBIT exchange app tied to the WhiteBIT project
ensawards.org/data/apps/whitebit-exchange/icon.tsx Adds WhiteBIT exchange app icon component
ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx Adds WhiteBIT ENSv2-ready-resolution benchmark result + evidence
ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/deposit-addresses/index.tsx Adds WhiteBIT deposit-addresses benchmark results (with pending BTC/SOL marked undefined)
ensawards.org/data/apps/whitebit-exchange/benchmarks/index.tsx Registers WhiteBIT benchmarks in the benchmarks registry
ensawards.org/data/apps/ourbit-exchange/index.ts Registers the Ourbit exchange app tied to the Ourbit project
ensawards.org/data/apps/ourbit-exchange/icon.tsx Adds Ourbit exchange app icon component
ensawards.org/data/apps/ourbit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx Adds Ourbit ENSv2-ready-resolution benchmark result + evidence
ensawards.org/data/apps/ourbit-exchange/benchmarks/resolution/deposit-addresses/index.tsx Adds Ourbit deposit-addresses benchmark results + evidence
ensawards.org/data/apps/ourbit-exchange/benchmarks/index.tsx Registers Ourbit benchmarks in the benchmarks registry
ensawards.org/data/apps/bitunix-exchange/index.ts Registers the Bitunix exchange app tied to the Bitunix project
ensawards.org/data/apps/bitunix-exchange/icon.tsx Adds Bitunix exchange app icon component
ensawards.org/data/apps/bitunix-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx Adds Bitunix ENSv2-ready-resolution benchmark result + evidence
ensawards.org/data/apps/bitunix-exchange/benchmarks/resolution/deposit-addresses/index.tsx Adds Bitunix deposit-addresses benchmark results + evidence
ensawards.org/data/apps/bitunix-exchange/benchmarks/index.tsx Registers Bitunix benchmarks in the benchmarks registry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx`:
- Around line 4-6: The imports in the benchmark entry are split between a
type-only import and a value import from the same module; combine them into a
single statement in the `index.tsx` benchmark file, using the same pattern as
`deposit-addresses/index.tsx`. Keep `AcceptanceTestBenchmark` from
`data/acceptance-tests/types` separate, but merge `AcceptanceTestBenchmarks` and
`BenchmarkResults` from `data/benchmarks/types` into one import so the module is
only referenced once.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0769776a-7561-4602-8074-eb8a9583afa8

📥 Commits

Reviewing files that changed from the base of the PR and between 10663dd and 9ab5959.

⛔ Files ignored due to path filters (16)
  • ensawards.org/data/apps/bitunix-exchange/benchmarks/resolution/deposit-addresses/at-1.png is excluded by !**/*.png
  • ensawards.org/data/apps/bitunix-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.png is excluded by !**/*.png
  • ensawards.org/data/apps/bitunix-exchange/icon.png is excluded by !**/*.png
  • ensawards.org/data/apps/ourbit-exchange/benchmarks/resolution/deposit-addresses/at-1.png is excluded by !**/*.png
  • ensawards.org/data/apps/ourbit-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.png is excluded by !**/*.png
  • ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/deposit-addresses/at-1.png is excluded by !**/*.png
  • ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/deposit-addresses/at-2.png is excluded by !**/*.png
  • ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/deposit-addresses/at-3.png is excluded by !**/*.png
  • ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/deposit-addresses/at-4.png is excluded by !**/*.png
  • ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/deposit-addresses/at-5.png is excluded by !**/*.png
  • ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.png is excluded by !**/*.png
  • ensawards.org/data/apps/xtcom-exchange/benchmarks/resolution/deposit-addresses/at-1.png is excluded by !**/*.png
  • ensawards.org/data/apps/xtcom-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.png is excluded by !**/*.png
  • ensawards.org/data/apps/xtcom-exchange/icon.jpeg is excluded by !**/*.jpeg
  • ensawards.org/data/projects/bitunix/icon.png is excluded by !**/*.png
  • ensawards.org/data/projects/xtcom/icon.jpeg is excluded by !**/*.jpeg
📒 Files selected for processing (29)
  • ensawards.org/data/apps/bitunix-exchange/benchmarks/index.tsx
  • ensawards.org/data/apps/bitunix-exchange/benchmarks/resolution/deposit-addresses/index.tsx
  • ensawards.org/data/apps/bitunix-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx
  • ensawards.org/data/apps/bitunix-exchange/icon.tsx
  • ensawards.org/data/apps/bitunix-exchange/index.ts
  • ensawards.org/data/apps/ourbit-exchange/benchmarks/index.tsx
  • ensawards.org/data/apps/ourbit-exchange/benchmarks/resolution/deposit-addresses/index.tsx
  • ensawards.org/data/apps/ourbit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx
  • ensawards.org/data/apps/ourbit-exchange/icon.tsx
  • ensawards.org/data/apps/ourbit-exchange/index.ts
  • ensawards.org/data/apps/whitebit-exchange/benchmarks/index.tsx
  • ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/deposit-addresses/index.tsx
  • ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx
  • ensawards.org/data/apps/whitebit-exchange/icon.tsx
  • ensawards.org/data/apps/whitebit-exchange/index.ts
  • ensawards.org/data/apps/xtcom-exchange/benchmarks/index.tsx
  • ensawards.org/data/apps/xtcom-exchange/benchmarks/resolution/deposit-addresses/index.tsx
  • ensawards.org/data/apps/xtcom-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx
  • ensawards.org/data/apps/xtcom-exchange/icon.tsx
  • ensawards.org/data/apps/xtcom-exchange/index.ts
  • ensawards.org/data/projects/bitunix/icon.tsx
  • ensawards.org/data/projects/bitunix/index.ts
  • ensawards.org/data/projects/ourbit/icon.tsx
  • ensawards.org/data/projects/ourbit/index.ts
  • ensawards.org/data/projects/types.ts
  • ensawards.org/data/projects/whitebit/icon.tsx
  • ensawards.org/data/projects/whitebit/index.ts
  • ensawards.org/data/projects/xtcom/icon.tsx
  • ensawards.org/data/projects/xtcom/index.ts

@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds four new exchange apps — Ourbit, XT.COM, Bitunix, and WhiteBIT — each with a project definition, app definition, icons, and benchmarks for the deposit-addresses and ensv2-ready-resolution best practice categories.

  • Ourbit, Bitunix, XT.COM: All three fail AT01 (no ENS support in the withdrawal/address-management flow), making AT02–AT08 not applicable — results and notes follow the established pattern exactly.
  • WhiteBIT: The most complete entry; AT01–AT02 pass (basic ENS resolution works), AT03–AT05 fail (offchain names and cross-chain resolution unsupported), AT06/AT07 are correctly left as undefined pending a follow-up (issue Track and retry pending benchmarks #252), and the ENSv2-ready-resolution benchmark correctly records a Fail because the resolved address doesn't match the expected Mainnet address.
  • data/projects/types.ts: Four new ProjectIds constants are added following the existing pattern.

Confidence Score: 5/5

Safe to merge — all four exchanges follow the established data structure exactly and the only finding is a lowercase/uppercase brand-name inconsistency in one alt text.

All new files are purely additive data entries that closely follow the patterns set by existing exchanges. WhiteBIT's undefined benchmark slots for AT06/AT07 are intentional and correctly typed per the AcceptanceTestBenchmarks definition, with a tracking issue already open. No logic, type safety, or runtime concerns were identified.

No files require special attention beyond the minor alt-text correction in xtcom-exchange/benchmarks/resolution/deposit-addresses/index.tsx.

Important Files Changed

Filename Overview
ensawards.org/data/projects/types.ts Adds four new ProjectIds (Bitunix, XTcom, WhiteBIT, Ourbit) following the established pattern.
ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/deposit-addresses/index.tsx WhiteBIT deposit-addresses benchmark with AT01/AT02 passing, AT03–AT05 failing, AT06/AT07 correctly set to undefined (pending per issue #252), and AT08 marked NotApplicable referencing AT05.
ensawards.org/data/apps/whitebit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx WhiteBIT ENSv2 resolution benchmark correctly marked as Fail — the app resolves a wrong address instead of the expected Mainnet address.
ensawards.org/data/apps/xtcom-exchange/benchmarks/resolution/deposit-addresses/index.tsx XT.COM deposit-addresses benchmark; all results are correct, but the AT01 alt text uses "XT.com" instead of the canonical brand name "XT.COM".
ensawards.org/data/apps/ourbit-exchange/index.ts Ourbit app definition — id, slug, type, project reference, name, description, and socials all look correct.
ensawards.org/data/apps/bitunix-exchange/index.ts Bitunix app definition following the established structure; icon correctly uses fill="none" with an inner <image> element.
ensawards.org/data/apps/xtcom-exchange/index.ts XT.COM app definition correctly wired to XTcomProject; icon uses fill="none" as expected for raster-image-backed SVG wrappers.
ensawards.org/data/projects/whitebit/icon.tsx Inline SVG path icon for WhiteBIT; adds bg-white rounded-md to handle the dark logo correctly on light and dark backgrounds.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph New Exchanges - Tranche 4 Batch 3
        OE[Ourbit Exchange] --> OP[Ourbit Project]
        XE[XT.COM Exchange] --> XP[XT.COM Project]
        BE[Bitunix Exchange] --> BP[Bitunix Project]
        WE[WhiteBIT Exchange] --> WP[WhiteBIT Project]
    end

    subgraph Benchmarks - deposit-addresses
        OE --> ODA["AT01: Fail\nAT02-AT08: N/A"]
        XE --> XDA["AT01: Fail\nAT02-AT08: N/A"]
        BE --> BDA["AT01: Fail\nAT02-AT08: N/A"]
        WE --> WDA["AT01-02: Pass\nAT03-05: Fail\nAT06-07: undefined\nAT08: N/A"]
    end

    subgraph Benchmarks - ensv2-ready-resolution
        OE --> OER["N/A (no ENS support)"]
        XE --> XER["N/A (no ENS support)"]
        BE --> BER["N/A (no ENS support)"]
        WE --> WER["Fail (wrong address resolved)"]
    end
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    subgraph New Exchanges - Tranche 4 Batch 3
        OE[Ourbit Exchange] --> OP[Ourbit Project]
        XE[XT.COM Exchange] --> XP[XT.COM Project]
        BE[Bitunix Exchange] --> BP[Bitunix Project]
        WE[WhiteBIT Exchange] --> WP[WhiteBIT Project]
    end

    subgraph Benchmarks - deposit-addresses
        OE --> ODA["AT01: Fail\nAT02-AT08: N/A"]
        XE --> XDA["AT01: Fail\nAT02-AT08: N/A"]
        BE --> BDA["AT01: Fail\nAT02-AT08: N/A"]
        WE --> WDA["AT01-02: Pass\nAT03-05: Fail\nAT06-07: undefined\nAT08: N/A"]
    end

    subgraph Benchmarks - ensv2-ready-resolution
        OE --> OER["N/A (no ENS support)"]
        XE --> XER["N/A (no ENS support)"]
        BE --> BER["N/A (no ENS support)"]
        WE --> WER["Fail (wrong address resolved)"]
    end
Loading

Reviews (2): Last reviewed commit: "Apply AI agents' suggestions, pt.1" | Re-trigger Greptile

Comment on lines +26 to +30
"at01-resolve-onchain-name": {
result: BenchmarkResults.Pass,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-01T14:10:50Z") },
],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The timestamps for all eight WhiteBIT deposit-address entries ("2026-07-01T14:10:50Z") are identical to Ourbit's timestamps — down to the second. This looks like a copy-paste where the WhiteBIT times were never updated. If the benchmarks were genuinely run at a different time, the timestamps should reflect that.

Suggested change
"at01-resolve-onchain-name": {
result: BenchmarkResults.Pass,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-01T14:10:50Z") },
],
"at01-resolve-onchain-name": {
result: BenchmarkResults.Pass,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-07-01T<ACTUAL_TIME>Z") },
],

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benchmarks were added at the same time, so the identical timestamp makes sense and is legitimate.

Comment thread ensawards.org/data/apps/xtcom-exchange/icon.tsx Outdated
Comment thread ensawards.org/data/projects/xtcom/icon.tsx Outdated

@tk-o tk-o left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Y3drk Y3drk merged commit d43f7b5 into main Jul 2, 2026
12 checks passed
@Y3drk Y3drk deleted the y3drk/feat/add-exchanges-t4-b3 branch July 2, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ensawards ENSAwards related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants