Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ensawards.org/data/apps/bingx-exchange/benchmarks/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md
// for additional advice on adding and modifying app benchmarks

import BingXExchange from "data/apps/bingx-exchange";
import { defineAppBenchmarks } from "data/benchmarks/registry";
import type { BestPracticeBenchmarks } from "data/ens-best-practices/types";

import depositAddresses from "./resolution/deposit-addresses";
import ensv2ReadyResolution from "./resolution/ensv2-ready-resolution";

const benchmarks: BestPracticeBenchmarks = {
"ensv2-ready-resolution": ensv2ReadyResolution,
"deposit-addresses": depositAddresses,
};

defineAppBenchmarks(BingXExchange, benchmarks);

export default benchmarks;
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
// Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md
// for additional advice on adding and modifying app benchmarks

import { type AcceptanceTestBenchmarks, BenchmarkResults } from "data/benchmarks/types";
import contributors from "data/contributors";
import {
buildEnsNotSupportedNote,
buildNotApplicableForFailedTest,
} from "data/ens-best-practices/resolution/deposit-addresses/notes";

import { parseTimestamp } from "@ensnode/ensnode-sdk";

import at1Proof from "./at-1.png";

const depositAddresses = {
"at01-resolve-onchain-name": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-29T13:52:05Z") },
],
notes: buildEnsNotSupportedNote({
method: 'the "withdraw" flow',
proof: {
image: at1Proof,
alt: "BingX Exchange doesn't allow ENS names as the recipient in the withdraw flow",
},
}),
},
"at02-resolve-name-needing-normalization": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-29T13:52:05Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 1 }),
},
"at03-resolve-offchain-eth-subname": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-29T13:52:05Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 1 }),
},
"at04-resolve-offchain-dns-name": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-29T13:52:05Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 1 }),
},
"at05-resolve-name-on-other-evm-chain": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-29T13:52:05Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 1 }),
},
"at06-resolve-bitcoin-address": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-29T13:52:05Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 1 }),
},
"at07-resolve-solana-address": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-29T13:52:05Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 1 }),
},
"at08-handle-invalid-address-format": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-29T13:52:05Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 1 }),
},
} as const satisfies AcceptanceTestBenchmarks;

export default depositAddresses;
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
// Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md
// for additional advice on adding and modifying app benchmarks

import type { AcceptanceTestBenchmark } from "data/acceptance-tests/types";
import type { AcceptanceTestBenchmarks } from "data/benchmarks/types";
import { BenchmarkResults } from "data/benchmarks/types";
import contributors from "data/contributors";
import { acceptanceTestDetailsContainerStyles } from "data/ens-best-practices/styles";

import { parseTimestamp } from "@ensnode/ensnode-sdk";

import { cn } from "@/utils/tailwindClassConcatenation";

import correctlyResolveEnsv2TestNameAddressProofImage from "./at-1.png";

const ensv2ReadyResolution = {
"correctly-resolve-ensv2-test-name-address": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-29T13:50:45Z") },
],
notes: (
<div className={cn(acceptanceTestDetailsContainerStyles, "w-full")}>
<p className="w-full">
ENSv2 ready resolution was tested using the &quot;withdraw&quot; flow. The app doesn't
support the use of ENS names at all as the recipient identifier.
<br />
<br />
While that's a key issue that this app is encouraged to improve, this best practice is
applicable specifically to apps that already have an existing ENS integration and making
sure existing integrations are ENSv2 compatible. Therefore, for this best practice we
apply a rating of not applicable.
</p>
<img
alt="BingX exchange doesn't allow ENS name as recipient in the withdraw flow"
src={correctlyResolveEnsv2TestNameAddressProofImage.src}
className="w-auto h-full max-h-[325px] rounded-xl"
/>
</div>
),
} as const satisfies AcceptanceTestBenchmark,
} as const satisfies AcceptanceTestBenchmarks;

export default ensv2ReadyResolution;
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 19 additions & 0 deletions ensawards.org/data/apps/bingx-exchange/icon.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import React from "react";

import { cn } from "@/utils/tailwindClassConcatenation";

import icon from "./icon.jpeg";

const Icon = ({ className, ...props }: React.SVGProps<SVGSVGElement>) => (
<svg
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 24 24"
fill="none"
className={cn("rounded-md", className)}
{...props}
>
<image href={icon.src} width="24" height="24" />
</svg>
);

export default Icon;
28 changes: 28 additions & 0 deletions ensawards.org/data/apps/bingx-exchange/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md
// for additional advice on adding and modifying apps

import BingXProject from "data/projects/bingx";

import { defineApp } from "../registry.ts";
import { type App, AppTypes } from "../types.ts";
import BingXIcon from "./icon.tsx";

const BingXExchange: App = {
id: "bingx-exchange",
appSlug: "bingx-exchange",
type: AppTypes.Exchange,
project: BingXProject,
name: "BingX",
description:
"Cryptocurrency exchange for spot, futures, and copy trading, buying, selling, and managing digital assets.",
socials: {
website: new URL("https://bingx.com"),
twitter: new URL("https://x.com/BingXOfficial"),
},
icon: BingXIcon,
// TODO: Add OG images
};

defineApp(BingXExchange);

export default BingXExchange;
18 changes: 18 additions & 0 deletions ensawards.org/data/apps/bitfinex-exchange/benchmarks/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md
// for additional advice on adding and modifying app benchmarks

import BitfinexExchange from "data/apps/bitfinex-exchange";
import { defineAppBenchmarks } from "data/benchmarks/registry";
import type { BestPracticeBenchmarks } from "data/ens-best-practices/types";

import depositAddresses from "./resolution/deposit-addresses";
import ensv2ReadyResolution from "./resolution/ensv2-ready-resolution";

const benchmarks: BestPracticeBenchmarks = {
"ensv2-ready-resolution": ensv2ReadyResolution,
"deposit-addresses": depositAddresses,
};

defineAppBenchmarks(BitfinexExchange, benchmarks);

export default benchmarks;
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
// Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md
// for additional advice on adding and modifying app benchmarks

import { type AcceptanceTestBenchmarks, BenchmarkResults } from "data/benchmarks/types";
import contributors from "data/contributors";
import {
buildFailNoteForAT2,
buildFailNoteForAT3,
buildFailNoteForAT4,
buildFailNoteForAT6,
buildFailNoteForAT7,
buildNotApplicableForEvmChain,
buildNotApplicableForFailedTest,
buildPassNoteForAT1,
} from "data/ens-best-practices/resolution/deposit-addresses/notes";

import { parseTimestamp } from "@ensnode/ensnode-sdk";

import at1Proof from "./at-1.png";
import at2Proof from "./at-2.png";
import at3Proof from "./at-3.png";
import at4Proof from "./at-4.png";
import at5Proof from "./at-5.gif";
import at6Proof from "./at-6.png";
import at7Proof from "./at-7.png";

const method = 'the "Address book" feature';

const depositAddresses = {
"at01-resolve-onchain-name": {
result: BenchmarkResults.Pass,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-30T09:26:44Z") },
],
notes: buildPassNoteForAT1({
method,
proof: {
image: at1Proof,
alt: "Bitfinex Exchange correctly resolves the address for vitalik.eth",
},
}),
},
"at02-resolve-name-needing-normalization": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-30T09:26:44Z") },
],
notes: buildFailNoteForAT2({
method,
proof: {
image: at2Proof,
alt: "Bitfinex Exchange fails to resolve the address for Ξthereum.eth",
},
extra: 'The app showed the message "Invalid address".',
}),
},
"at03-resolve-offchain-eth-subname": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-30T09:26:44Z") },
],
notes: buildFailNoteForAT3({
method,
proof: {
image: at3Proof,
alt: "Bitfinex Exchange fails to resolve the address for jesse.base.eth",
},
extra: 'The app showed the message "Invalid address".',
}),
},
"at04-resolve-offchain-dns-name": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-30T09:26:44Z") },
],
notes: buildFailNoteForAT4({
method,
proof: {
image: at4Proof,
alt: "Bitfinex Exchange fails to resolve the address for dperri.com",
},
extra: 'The app showed the message "Invalid address".',
}),
},
"at05-resolve-name-on-other-evm-chain": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-30T09:26:44Z") },
],
notes: buildNotApplicableForEvmChain({
chain: "Base",
proof: {
image: at5Proof,
alt: "Bitfinex Exchange has no context of the Base chain in the Address book feature",
},
}),
},
"at06-resolve-bitcoin-address": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-30T09:26:44Z") },
],
notes: buildFailNoteForAT6({
method: 'the "Address book" feature in context of the Bitcoin chain',
proof: {
image: at6Proof,
alt: "Bitfinex Exchange fails to resolve the Bitcoin address for gregskril.eth",
},
extra: 'The app showed the message "Invalid address".',
}),
},
"at07-resolve-solana-address": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-30T09:26:44Z") },
],
notes: buildFailNoteForAT7({
method: 'the "Address book" feature in context of the Solana chain',
proof: {
image: at7Proof,
alt: "Bitfinex Exchange fails to resolve the Solana address for gregskril.eth",
},
extra: 'The app showed the message "Invalid address".',
}),
},
"at08-handle-invalid-address-format": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-30T09:26:44Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 5, scope: "on Base" }),
},
} as const satisfies AcceptanceTestBenchmarks;

export default depositAddresses;
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
// Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md
// for additional advice on adding and modifying app benchmarks

import type { AcceptanceTestBenchmark } from "data/acceptance-tests/types";
import type { AcceptanceTestBenchmarks } from "data/benchmarks/types";
import { BenchmarkResults } from "data/benchmarks/types";
import contributors from "data/contributors";
import {
acceptanceTestDetailsContainerStyles,
bestPracticeTechnicalDetailsCodeStyles,
} from "data/ens-best-practices/styles";

import { parseTimestamp } from "@ensnode/ensnode-sdk";

import { cn } from "@/utils/tailwindClassConcatenation";

import at1ProofImage from "./at-1.png";

const ensv2ReadyResolution = {
"correctly-resolve-ensv2-test-name-address": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-30T09:20:00Z") },
],
notes: (
<div className={cn(acceptanceTestDetailsContainerStyles, "w-full")}>
<p className="w-full">
ENSv2 ready resolution was tested using the &quot;Address book&quot; feature. The resolved
address is <i>NOT</i> the expected Ethereum Mainnet address (
<span className={bestPracticeTechnicalDetailsCodeStyles}>
0x2222222222222222222222222222222222222222
</span>
).
</p>
<img
alt="Bitfinex exchange fails to resolve the name for ENSv2"
src={at1ProofImage.src}
className="w-auto h-full max-h-[325px] rounded-xl"
/>
</div>
),
} as const satisfies AcceptanceTestBenchmark,
} as const satisfies AcceptanceTestBenchmarks;

export default ensv2ReadyResolution;
Loading
Loading