feat: Add new apps - tranche 4 - exchanges batch 1#250
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds five new exchange apps (BingX, Bitfinex, Bitget, Gate, HTX) to the ENS Awards data layer. Each exchange receives a project definition, icon component, app registration, and acceptance-test benchmarks for ChangesExchange App and Benchmark Additions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds five new
Confidence Score: 5/5Safe to merge — all changes are additive data entries following established patterns, with only a minor social-link inconsistency in the HTX entries. All five new exchange apps and their benchmark files are purely additive and structurally identical to existing entries in the codebase. The Kraken rename (deposit-address → deposit-addresses) correctly updates both the directory and the import. The only notable inconsistency is HTX using twitter.com instead of x.com for its social links, which has no runtime impact. ensawards.org/data/apps/htx-exchange/index.ts and ensawards.org/data/projects/htx/index.ts use twitter.com while all other entries in the PR use x.com. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
PT[projects/types.ts
ProjectIds enum] --> BP[projects/bingx]
PT --> BT[projects/bitfinex]
PT --> BG[projects/bitget]
PT --> GA[projects/gate]
PT --> HT[projects/htx]
BP --> BA[apps/bingx-exchange]
BT --> BFA[apps/bitfinex-exchange]
BG --> BGA[apps/bitget-exchange]
GA --> GEA[apps/gate-exchange]
HT --> HTA[apps/htx-exchange]
BA --> BBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
BFA --> BFBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
BGA --> BGBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
GEA --> GBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
HTA --> HBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
KR[apps/kraken-exchange] --> KBM[benchmarks/
deposit-addresses
deposit-address REMOVED]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
PT[projects/types.ts
ProjectIds enum] --> BP[projects/bingx]
PT --> BT[projects/bitfinex]
PT --> BG[projects/bitget]
PT --> GA[projects/gate]
PT --> HT[projects/htx]
BP --> BA[apps/bingx-exchange]
BT --> BFA[apps/bitfinex-exchange]
BG --> BGA[apps/bitget-exchange]
GA --> GEA[apps/gate-exchange]
HT --> HTA[apps/htx-exchange]
BA --> BBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
BFA --> BFBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
BGA --> BGBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
GEA --> GBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
HTA --> HBM[benchmarks/
deposit-addresses
ensv2-ready-resolution]
KR[apps/kraken-exchange] --> KBM[benchmarks/
deposit-addresses
deposit-address REMOVED]
Reviews (3): Last reviewed commit: "Apply AI agents' suggestions, pt.1" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Adds tranche-4 “exchange” entries (projects + apps) and wires in resolution best-practice benchmark data, including filling in Kraken Exchange’s deposit-addresses benchmarks.
Changes:
- Added new
exchangeprojects: Bitget, HTX, BingX, Gate, Bitfinex (incl. icons andProjectIdsentries). - Added new exchange apps for those projects (incl. icons) and registered resolution benchmarks (
ensv2-ready-resolution,deposit-addresses). - Replaced Kraken Exchange’s placeholder
deposit-addressbenchmark stub with a concretedeposit-addressesbenchmark implementation and updated its benchmarks index import.
Reviewed changes
Copilot reviewed 39 out of 66 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ensawards.org/data/projects/types.ts | Adds new ProjectIds entries for the new exchange projects. |
| ensawards.org/data/projects/htx/index.ts | Defines and registers the HTX project metadata. |
| ensawards.org/data/projects/htx/icon.tsx | Adds HTX project icon component (image-backed SVG). |
| ensawards.org/data/projects/gate/index.ts | Defines and registers the Gate project metadata. |
| ensawards.org/data/projects/gate/icon.tsx | Adds Gate project icon component (inline SVG). |
| ensawards.org/data/projects/bitget/index.ts | Defines and registers the Bitget project metadata. |
| ensawards.org/data/projects/bitget/icon.tsx | Adds Bitget project icon component (inline SVG). |
| ensawards.org/data/projects/bitfinex/index.ts | Defines and registers the Bitfinex project metadata. |
| ensawards.org/data/projects/bitfinex/icon.tsx | Adds Bitfinex project icon component (inline SVG). |
| ensawards.org/data/projects/bingx/index.ts | Defines and registers the BingX project metadata. |
| ensawards.org/data/projects/bingx/icon.tsx | Adds BingX project icon component (image-backed SVG). |
| ensawards.org/data/apps/kraken-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds Kraken Exchange deposit-addresses benchmark results/notes. |
| ensawards.org/data/apps/kraken-exchange/benchmarks/resolution/deposit-address/index.tsx | Removes the old placeholder stub benchmark file. |
| ensawards.org/data/apps/kraken-exchange/benchmarks/index.tsx | Updates Kraken Exchange benchmarks import to deposit-addresses. |
| ensawards.org/data/apps/htx-exchange/index.ts | Adds HTX Exchange app definition and registration. |
| ensawards.org/data/apps/htx-exchange/icon.tsx | Adds HTX Exchange app icon component. |
| ensawards.org/data/apps/htx-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds HTX Exchange ENSv2-ready-resolution benchmark results/notes. |
| ensawards.org/data/apps/htx-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds HTX Exchange deposit-addresses benchmark results/notes. |
| ensawards.org/data/apps/htx-exchange/benchmarks/index.tsx | Registers HTX Exchange benchmark set. |
| ensawards.org/data/apps/gate-exchange/index.ts | Adds Gate Exchange app definition and registration. |
| ensawards.org/data/apps/gate-exchange/icon.tsx | Adds Gate Exchange app icon component. |
| ensawards.org/data/apps/gate-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds Gate Exchange ENSv2-ready-resolution benchmark results/notes. |
| ensawards.org/data/apps/gate-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds Gate Exchange deposit-addresses benchmark results/notes. |
| ensawards.org/data/apps/gate-exchange/benchmarks/index.tsx | Registers Gate Exchange benchmark set. |
| ensawards.org/data/apps/bitget-exchange/index.ts | Adds Bitget Exchange app definition and registration. |
| ensawards.org/data/apps/bitget-exchange/icon.tsx | Adds Bitget Exchange app icon component. |
| ensawards.org/data/apps/bitget-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds Bitget Exchange ENSv2-ready-resolution benchmark results/notes. |
| ensawards.org/data/apps/bitget-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds Bitget Exchange deposit-addresses benchmark results/notes. |
| ensawards.org/data/apps/bitget-exchange/benchmarks/index.tsx | Registers Bitget Exchange benchmark set. |
| ensawards.org/data/apps/bitfinex-exchange/index.ts | Adds Bitfinex Exchange app definition and registration. |
| ensawards.org/data/apps/bitfinex-exchange/icon.tsx | Adds Bitfinex Exchange app icon component. |
| ensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds Bitfinex Exchange ENSv2-ready-resolution benchmark results/notes. |
| ensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds Bitfinex Exchange deposit-addresses benchmark results/notes. |
| ensawards.org/data/apps/bitfinex-exchange/benchmarks/index.tsx | Registers Bitfinex Exchange benchmark set. |
| ensawards.org/data/apps/bingx-exchange/index.ts | Adds BingX Exchange app definition and registration. |
| ensawards.org/data/apps/bingx-exchange/icon.tsx | Adds BingX Exchange app icon component. |
| ensawards.org/data/apps/bingx-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds BingX Exchange ENSv2-ready-resolution benchmark results/notes. |
| ensawards.org/data/apps/bingx-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds BingX Exchange deposit-addresses benchmark results/notes. |
| ensawards.org/data/apps/bingx-exchange/benchmarks/index.tsx | Registers BingX Exchange benchmark set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rk/feat/add-exchanges-t4
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ensawards.org/data/apps/bitget-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx`:
- Around line 30-33: The proof image alt text in the benchmark screenshot is
still referring to the wrong exchange, so update the <img> element in the
relevant index.tsx render block to use Bitget-specific wording instead of “Bybit
exchange”. Keep the change localized to the alt attribute tied to at1ProofImage
so screen readers and reviewers see the correct app label.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 530965af-ed81-4822-9c6e-ee075875ffc2
⛔ Files ignored due to path filters (27)
ensawards.org/data/apps/bingx-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bingx-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bingx-exchange/icon.jpegis excluded by!**/*.jpegensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/deposit-addresses/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bitget-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/gate-exchange/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/gate-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/htx-exchange/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/htx-exchange/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/htx-exchange/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/htx-exchange/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/htx-exchange/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/htx-exchange/benchmarks/resolution/deposit-addresses/at-6.gifis excluded by!**/*.gifensawards.org/data/apps/htx-exchange/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/htx-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/htx-exchange/icon.jpgis excluded by!**/*.jpgensawards.org/data/apps/kraken-exchange/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/projects/bingx/icon.jpegis excluded by!**/*.jpegensawards.org/data/projects/htx/icon.jpgis excluded by!**/*.jpg
📒 Files selected for processing (39)
ensawards.org/data/apps/bingx-exchange/benchmarks/index.tsxensawards.org/data/apps/bingx-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/bingx-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/bingx-exchange/icon.tsxensawards.org/data/apps/bingx-exchange/index.tsensawards.org/data/apps/bitfinex-exchange/benchmarks/index.tsxensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/bitfinex-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/bitfinex-exchange/icon.tsxensawards.org/data/apps/bitfinex-exchange/index.tsensawards.org/data/apps/bitget-exchange/benchmarks/index.tsxensawards.org/data/apps/bitget-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/bitget-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/bitget-exchange/icon.tsxensawards.org/data/apps/bitget-exchange/index.tsensawards.org/data/apps/gate-exchange/benchmarks/index.tsxensawards.org/data/apps/gate-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/gate-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/gate-exchange/icon.tsxensawards.org/data/apps/gate-exchange/index.tsensawards.org/data/apps/htx-exchange/benchmarks/index.tsxensawards.org/data/apps/htx-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/htx-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/htx-exchange/icon.tsxensawards.org/data/apps/htx-exchange/index.tsensawards.org/data/apps/kraken-exchange/benchmarks/index.tsxensawards.org/data/apps/kraken-exchange/benchmarks/resolution/deposit-address/index.tsxensawards.org/data/apps/kraken-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/projects/bingx/icon.tsxensawards.org/data/projects/bingx/index.tsensawards.org/data/projects/bitfinex/icon.tsxensawards.org/data/projects/bitfinex/index.tsensawards.org/data/projects/bitget/icon.tsxensawards.org/data/projects/bitget/index.tsensawards.org/data/projects/gate/icon.tsxensawards.org/data/projects/gate/index.tsensawards.org/data/projects/htx/icon.tsxensawards.org/data/projects/htx/index.tsensawards.org/data/projects/types.ts
💤 Files with no reviewable changes (1)
- ensawards.org/data/apps/kraken-exchange/benchmarks/resolution/deposit-address/index.tsx
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lite PR → Add new apps - tranche 4 - exchanges batch 1
Summary
exchange(listed below)resolutionbest practice category.deposit-addressesbenchmarks for Kraken Exchange (the app itself was already added)Why
Testing
typecheck,lint, andtestcommands locally to ensure that the migration didn't break anything, and later confirmed that in our CI workflowPre-Review Checklist (Blocking)