Skip to content

MILAB-5933: honour an explicit request-timeout in test configs #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xnacly wants to merge 1 commit into
base: MILAB-5933_hz-e2e-runner-fix
Choose a base branch
from
Open

MILAB-5933: honour an explicit request-timeout in test configs #1785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/node/pl-client/src/test/test_config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,16 @@ export function getTestConfig(): TestConfig {
/** Default request timeout for tests (ms) */
export const TEST_REQUEST_TIMEOUT = 500;

/** Returns PlClientConfig with reduced timeout for tests */
/** Returns PlClientConfig with reduced timeout for tests, unless the address sets its own */
export function plAddressToTestConfig(address: string): PlClientConfig {
const plConf = plAddressToConfig(address);
plConf.defaultRequestTimeout = TEST_REQUEST_TIMEOUT;
// An explicit request-timeout in the address wins over TEST_REQUEST_TIMEOUT. In the k8s e2e
// deploy the client dials a cluster service DNS name, and the first call on a cold channel must
// finish name resolution and get a load-balancer pick before it is even sent; 500ms does not
// cover that, so whichever test happened to open the cold channel died with DEADLINE_EXCEEDED
// ("Waiting for LB pick") against a healthy backend. Addresses that carry no request-timeout
// keep the short default, so local runs still fail fast.
if (!/[?&]request-timeout=/.test(address)) plConf.defaultRequestTimeout = TEST_REQUEST_TIMEOUT;
return plConf;
}

Expand Down