MILAB-5933: honour an explicit request-timeout in test configs - #1785
Open
xnacly wants to merge 1 commit into
Open
MILAB-5933: honour an explicit request-timeout in test configs#1785xnacly wants to merge 1 commit into
xnacly wants to merge 1 commit into
Conversation
…t configs plAddressToTestConfig overwrote the parsed defaultRequestTimeout with a flat 500ms, discarding the request-timeout=3000 the e2e CI puts in PL_ADDRESS. Against a cluster service DNS name the first call on a cold channel has to resolve DNS and get an LB pick inside that budget, so whichever test opened the cold channel failed with DEADLINE_EXCEEDED against a healthy backend - a different test each run, which read as flakiness. Addresses without request-timeout keep the 500ms default.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plAddressToTestConfig parsed the address and then overwrote
defaultRequestTimeoutwith a flat 500ms, so therequest-timeout=3000the pl e2e job puts inPL_ADDRESSnever took effect.Invisible against localhost, fatal against the k8s service DNS name: a cold gRPC channel cannot resolve and get an LB pick inside 500ms, so whichever test opened it failed with
Deadline exceeded after 0.498s ... Waiting for LB pickagainst a healthy backend. Addresses withoutrequest-timeoutkeep the short default.Greptile Summary
The PR preserves an explicitly parsed
request-timeoutwhen creating test client configuration while retaining the short 500ms default for addresses without that parameter.plAddressToTestConfigso an address-level timeout takes precedence overTEST_REQUEST_TIMEOUT.PlClientConfig: The parsed client connection configuration; itsdefaultRequestTimeoutis no longer unconditionally overwritten by the test helper.plAddressToTestConfig: The test configuration adapter; it now applies the 500ms test timeout only when the address does not specifyrequest-timeout.request-timeout: An address query parameter defining the default request deadline; explicit values such as 3000ms are now honored in tests.TEST_REQUEST_TIMEOUT: The 500ms fail-fast default for tests; it remains active for addresses without an explicit timeout.Confidence Score: 5/5
The PR appears safe to merge, with the intended explicit Kubernetes request timeout now preserved and no actionable regression established.
The changed helper continues applying the 500ms test default when no timeout parameter is present and retains the parsed numeric timeout for the supported CI address form.
Important Files Changed
Reviews (1): Last reviewed commit: "MILAB-5933: honour an explicit request-t..." | Re-trigger Greptile
Context used: