feat(AutoPilotPlugin): don't auto-switch to Vehicle Configuration on incomplete setup#14644
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the vehicle connection/setup flow in AutoPilotPlugin to stop forcibly switching the UI into Vehicle Configuration when a vehicle connects with incomplete setup, while still notifying the user that configuration tasks remain.
Changes:
- Removed the automatic UI navigation to Vehicle Configuration from
AutoPilotPlugin::parametersReadyPreChecks(). - Updated the user-facing notification text to reference “Vehicle Configuration”.
- Deleted the now-unused C++ slot
QGCApplication::showVehicleConfig()(QMLmainWindow.showVehicleConfig()remains in use by toolbar UI).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/QGCApplication.h | Removes the showVehicleConfig() slot declaration. |
| src/QGCApplication.cc | Removes the showVehicleConfig() implementation that invoked QML. |
| src/AutoPilotPlugins/AutoPilotPlugin.cc | Stops auto-switching views on incomplete setup; keeps a user notification with updated wording. |
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 0 passed, 0 failed, 0 skipped. Test Resultslinux-coverage-integration: 33 passed, 0 skipped Code CoverageCoverage: 67.8% No baseline available for comparison Artifact Sizes
Updated: 2026-07-19 19:18:58 UTC • Commit: ed22cb5 • Triggered by: Android |
…incomplete setup Keep the app message notifying the user that configuration tasks remain, but no longer force the UI to the Vehicle Configuration view when a vehicle connects with incomplete component setup. Also update the message wording to match current UI terminology and remove the now-dead QGCApplication::showVehicleConfig().
e5aecb8 to
ed22cb5
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #14644 +/- ##
==========================================
+ Coverage 25.47% 31.56% +6.09%
==========================================
Files 769 785 +16
Lines 65912 66979 +1067
Branches 30495 31027 +532
==========================================
+ Hits 16788 21140 +4352
+ Misses 37285 31467 -5818
- Partials 11839 14372 +2533
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 452 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Description
When a vehicle connects with incomplete component setup, QGC currently forces the UI to the Vehicle Configuration view. This removes that automatic view switch while keeping the notification to the user.
Changes
AutoPilotPlugin::parametersReadyPreChecks()no longer callsshowVehicleConfig(); it only shows the app message.QGCApplication::showVehicleConfig()C++ method (the QMLmainWindow.showVehicleConfig()used by toolbar indicators is unchanged).