[#835] Create BRP client

Cargo.toml

@@ -61,6 +61,7 @@ aes-gcm = "0.11.0" # 118M downloads (RustCrypto)
 hkdf = "0.13.0" # 198M downloads (RustCrypto)
 postcard = { version = "1.1.3", default-features = false, features = ["alloc"] } # 42M downloads (James Munns)
 secrecy = "0.10.3" # 126M downloads (Tony Arcieri)
+structstruck = "0.5.1" # 212K downloads (Julius Michaelis)
 urlencoding = "2.1.3" # 213M downloads (Kornel)
 zeroize = "1.9.0" # 359M downloads (RustCrypto)
 
@@ -154,6 +155,7 @@ sqlx = { workspace = true, optional = true }
 subtle = { workspace = true }
 textris-pdf = { workspace = true }
 tokio = { workspace = true }
+structstruck = { workspace = true }
 tokio-util = { workspace = true }
 tower-http = { workspace = true }
 tracing = { workspace = true }

compose.yml

@@ -9,3 +9,12 @@ services:
       TZ: Europe/Amsterdam
     ports: ['127.0.0.1:5432:5432']
     networks: [default]
+
+  personen-mock:
+    container_name: brp-personen-mock
+    image: ghcr.io/brp-api/personen-mock:2.7.0-latest
+    environment:
+      - ASPNETCORE_ENVIRONMENT=Release
+      - ASPNETCORE_URLS=http://+:5010
+    ports:
+      - "5010:5010"

locales/en/audit_log.yml

@@ -40,6 +40,7 @@ documents:
 empty: No events have been recorded yet.
 event:
   add_candidate_to_list: Added candidate to list
+  brp_validation: Validated candidate against the BRP
   create_candidate_list: Created list of candidates
   create_name_authorisation: Created statutory name and authorised agent
   create_empty: Created empty political group

locales/nl/audit_log.yml

@@ -40,6 +40,7 @@ documents:
 empty: Er zijn nog geen gebeurtenissen vastgelegd.
 event:
   add_candidate_to_list: Kandidaat aan lijst toegevoegd
+  brp_validation: Kandidaat gevalideerd tegen de BRP
   create_candidate_list: Kandidatenlijst aangemaakt
   create_name_authorisation: Statutaire naam en gemachtigde aangemaakt
   create_empty: Lege politieke groepering aangemaakt

src/csb/import/pages/import.rs

@@ -1,3 +1,5 @@
+use std::time::Duration;
+
 use askama::Template;
 use axum::{
     extract::State,
@@ -6,15 +8,20 @@ use axum::{
 use serde::Deserialize;
 
 use crate::{
-    AppError, AppState, Context, CsbContext, CsbEvent, Form, HtmlTemplate, Locale, PgStoreData,
-    StreamId,
+    AppError, AppState, Context, CsbContext, CsbEvent, CsbStoreData, Form, HtmlTemplate, Locale,
+    PgStoreData, StreamId,
     csb::examination::{CsbExaminationOverviewPath, CsbPoliticalGroupPath},
-    filters, redirect_success, trans,
+    filters, redirect_success,
+    store::Store,
+    structs::brp::BrpClient,
+    trans,
     utils::parse_hash_prefix,
 };
 
 use super::{CsbCreateEmptyPath, CsbImportPath};
 
+const BRP_COURTESY_TIMEOUT: Duration = Duration::from_secs(1);
+
 #[derive(Template)]
 #[template(path = "csb/import/pages/import.html")]
 struct CsbImportTemplate {
@@ -121,6 +128,10 @@ async fn do_import(
         })
         .await?;
 
+    // TODO: get from env at higher level probably
+    let brp_client = BrpClient::new("http://localhost:5010", "", "haalcentraal/api/brp/personen");
+    do_brp_verification(&csb_store, &brp_client).await?;
+
     Ok(redirect_success(CsbPoliticalGroupPath {
         stream_id: csb_store.stream_id,
     }))
@@ -141,6 +152,48 @@ pub async fn create_empty(
     }))
 }
 
+pub async fn do_brp_verification(
+    store: &Store<CsbStoreData>,
+    brp_client: &BrpClient,
+) -> Result<(), AppError> {
+    let store = store.clone();
+    let brp_client = brp_client.clone();
+
+    tokio::task::spawn(async move {
+        store.data.write().brp_verification_in_progress = true;
+
+        let mut ticker = tokio::time::interval(BRP_COURTESY_TIMEOUT);
+        for person in store.get_persons() {
+            tracing::info!("Checking person {} against the brp", person.id);
+            ticker.tick().await;
+
+            match brp_client.verify(&person).await {
+                Ok(omissions) => {
+                    for omission in omissions {
+                        if let Err(err) = omission.create(&store).await {
+                            tracing::error!(
+                                "failed to record BRP omission for {}: {err}",
+                                person.id
+                            );
+                        }
+                    }
+                }
+                Err(err) => {
+                    tracing::error!("BRP verification failed for {}: {err}", person.id);
+                }
+            }
+        }
+
+        tracing::info!(
+            "Finished checking candidates on list {:?}",
+            store.data.read().imported_data.political_group
+        );
+        store.data.write().brp_verification_in_progress = false;
+    });
+
+    Ok(())
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;

src/csb/store_csb/event.rs

@@ -2,6 +2,7 @@ use serde::{Deserialize, Serialize};
 
 use crate::{
     Event, PgEvent, PgStoreData, StreamId,
+    persons::PersonId,
     structs::csb::{Correction, Omission, OmissionId},
     trans,
     utils::format_hash,
@@ -40,6 +41,10 @@ pub enum CsbEvent {
         omission_id: OmissionId,
     },
     UpdateCorrection(Correction),
+    BrpValidation {
+        person: PersonId,
+        valid: bool,
+    },
 }
 
 impl Event for CsbEvent {
@@ -53,6 +58,7 @@ impl Event for CsbEvent {
             | CsbEvent::UpdateOmission(_)
             | CsbEvent::DeleteOmission { .. } => "omission",
             CsbEvent::UpdateCorrection(_) => "correction",
+            CsbEvent::BrpValidation { .. } => "brp_validation",
         }
     }
 
@@ -66,6 +72,7 @@ impl Event for CsbEvent {
             CsbEvent::UpdateOmission(_) => "update_omission",
             CsbEvent::DeleteOmission { .. } => "delete_omission",
             CsbEvent::UpdateCorrection(_) => "update_correction",
+            CsbEvent::BrpValidation { .. } => "brep_validation",
         }
     }
 
@@ -81,6 +88,7 @@ impl Event for CsbEvent {
             CsbEvent::UpdateCorrection { .. } => {
                 trans!("audit_log.event.update_correction", locale)
             }
+            CsbEvent::BrpValidation { .. } => trans!("audit_log.event.brp_validation", locale),
         }
     }
 
@@ -102,6 +110,7 @@ impl Event for CsbEvent {
             CsbEvent::CreateOmission(o) | CsbEvent::UpdateOmission(o) => o.description.clone(),
             CsbEvent::DeleteOmission { omission_id } => omission_id.to_string(),
             CsbEvent::UpdateCorrection(_) => String::new(),
+            CsbEvent::BrpValidation { person, .. } => person.to_string(),
         }
     }
 

src/csb/store_csb/getters.rs

@@ -227,6 +227,12 @@ impl CsbStore {
             .collect()
     }
 
+    pub fn get_persons(&self) -> Vec<Person> {
+        let data = self.data.read();
+
+        data.imported_data.persons.values().cloned().collect()
+    }
+
     /// Return the single stored omission. Test-only helper for asserting on
     /// omissions whose category has no dedicated getter (e.g. candidate lists).
     #[cfg(test)]

src/csb/store_csb/mod.rs

@@ -30,6 +30,8 @@ pub struct CsbStoreData {
     pub(crate) omissions: HashMap<OmissionId, Omission>,
     pub(crate) csb_corrected_persons: HashMap<PersonId, Person>,
     pub(crate) csb_corrected_display_name: Option<DisplayName>,
+    pub(crate) brp_validations: HashMap<PersonId, bool>,
+    pub(crate) brp_verification_in_progress: bool,
 }
 
 impl StoreData for CsbStoreData {
@@ -108,6 +110,9 @@ impl StoreData for CsbStoreData {
                     correction.apply(person);
                 }
             },
+            CsbEvent::BrpValidation { person, valid } => {
+                self.brp_validations.insert(person, valid);
+            }
         }
     }
 

src/csb/store_main/mod.rs

@@ -2,11 +2,13 @@ mod event;
 mod extractor;
 
 pub use event::CsbMainEvent;
+use std::collections::HashMap;
 
 use serde::{Deserialize, Serialize};
 
 use crate::{
     Scope, StreamId,
+    persons::PersonId,
     store::{StoreData, StoreEvent},
 };
 
@@ -20,6 +22,7 @@ pub const CSB_MAIN_STREAM_ID: StreamId = StreamId(uuid::Uuid::from_u128(
 #[derive(Debug, Default, Serialize, Deserialize)]
 pub struct CsbMainStoreData {
     pub(crate) events: Vec<StoreEvent<CsbMainEvent>>,
+    pub(crate) brp_verifications: HashMap<PersonId, bool>,
 }
 
 impl StoreData for CsbMainStoreData {