You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR includes a first draft for querying the BRP and adds the docker personen mock service.
Open questions
How do we validate a person's last name? BRP contains a 'partners' field with registered marriages. Perhaps we need to cross-validate against this to see if these conditions hold:
For PR maintainer
Perform these checks before marking the PR as ready:
I have linked the PR to at least one issue.
I assigned the PR to myself.
I have added a description how to test this PR (see "Review Instructions").
I have added documentation where necessary.
For reviewer
I have read all code changes.
I have audited the code quality.
I have tested the changes either or both:
locally
on the test environment (preferred)
I have validated that the PR is functionally correct (use-cases, figma designs, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOD checklist
This PR includes a first draft for querying the BRP and adds the docker personen mock service.
Open questions
For PR maintainer
Perform these checks before marking the PR as ready:
For reviewer
Review instructions
insert a description on how to test this PR here