Skip to content

[#835] Create BRP client - #886

Draft
stefanvi wants to merge 33 commits into
mainfrom
create-brp-client
Draft

[#835] Create BRP client#886
stefanvi wants to merge 33 commits into
mainfrom
create-brp-client

Conversation

@stefanvi

@stefanvi stefanvi commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

DOD checklist

This PR includes a first draft for querying the BRP and adds the docker personen mock service.

Open questions

  • How do we validate a person's last name? BRP contains a 'partners' field with registered marriages. Perhaps we need to cross-validate against this to see if these conditions hold:
image

For PR maintainer

Perform these checks before marking the PR as ready:

  • I have linked the PR to at least one issue.
  • I assigned the PR to myself.
  • I have added a description how to test this PR (see "Review Instructions").
  • I have added documentation where necessary.

For reviewer

  • I have read all code changes.
  • I have audited the code quality.
  • I have tested the changes either or both:
    • locally
    • on the test environment (preferred)
  • I have validated that the PR is functionally correct (use-cases, figma designs, etc.)

Review instructions

insert a description on how to test this PR here

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

PDF diff summary

Template Input Status
model-h1 model-h1-example-1.pdf 🔵 identical
model-h1 model-h1-example-2.pdf 🔵 identical
model-h1 model-h1-example-3.pdf 🔵 identical
model-h3-1 model-h3-1-example-1.pdf 🔵 identical
model-h3-1 model-h3-1-example-2.pdf 🔵 identical
model-h3-1 model-h3-1-example-3.pdf 🔵 identical
model-h3-2 model-h3-2-example-1.pdf 🔵 identical
model-h3-2 model-h3-2-example-2.pdf 🔵 identical
model-h3-2 model-h3-2-example-3.pdf 🔵 identical
model-h4 model-h4-example-1.pdf 🔵 identical
model-h4 model-h4-example-2.pdf 🔵 identical
model-h4 model-h4-example-3.pdf 🔵 identical
model-h9 model-h9-example-1.pdf 🔵 identical
model-h9 model-h9-example-2.pdf 🔵 identical
model-h9 model-h9-example-3.pdf 🔵 identical
model-i4 model-i4-example-1.pdf 🔵 identical
model-i4 model-i4-example-2.pdf 🔵 identical

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Sigrid maintainability feedback


🔒Enable security insights in your CI pipeline to detect vulnerabilities early.
Start using Sigrid CI for Security today. Learn more.


⏸️️ You are still below your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-07-30.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 17 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Unit Size
(Introduced)
src/structs/brp/person.rs
BrpPerson.from(BrpPersonRaw)
🔴 Unit Size
(Worsened)
src/csb/store_csb/mod.rs
CsbStoreData.apply(StoreEvent<CsbEvent>)
🔴 Unit Size
(Introduced)
src/structs/brp/client.rs
BrpClient.verify(Person,Vec<CandidateListId>)
🔴 Module Coupling
(Worsened)
src/csb/store_csb/getters.rs
🟠 Unit Size
(Worsened)
src/state.rs
AppState.new_with_config(Config)
🟠 Unit Size
(Worsened)
src/core/config.rs
Config.from_env_with(F)
🟠 Unit Size
(Worsened)
src/csb/import/pages/import.rs
do_import(AppState,ImportForm,Locale)
🟠 Unit Size
(Introduced)
src/csb/import/pages/import.rs
verify_candidates(Store<CsbStoreData>,BrpClient)
⚪️ + 9 more

📚 Remaining technical debt

7 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-07-30 Before changes New/changed code
Volume N/A N/A N/A
Duplication 5.3 5.5 5.5
Unit Size 3.1 2.6 1.9
Unit Complexity 4.5 4.2 2.7
Unit Interfacing 2.4 2.8 3.9
Module Coupling 3.0 1.1 1.8
Component Independence 1.9 N/A N/A
Component Entanglement 1.6 N/A N/A
Maintainability 3.1 2.7 2.6

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@stefanvi
stefanvi force-pushed the create-brp-client branch from 20152eb to 83f6f13 Compare July 2, 2026 14:11
@stefanvi
stefanvi force-pushed the create-brp-client branch from 08b3f16 to f049590 Compare July 6, 2026 13:34
Comment thread src/structs/brp/client.rs Outdated
Comment thread src/structs/brp/client.rs
Comment thread src/structs/brp/client.rs Outdated
Comment thread src/structs/brp/person.rs Outdated
Comment thread src/structs/brp/person.rs
Comment thread src/csb/import/pages/import.rs Outdated
Comment thread src/csb/import/pages/import.rs Outdated
Comment thread src/csb/store_csb/event.rs Outdated
Comment thread src/structs/brp/client.rs Outdated
Comment thread src/structs/brp/client.rs Outdated
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants