Skip to content

VideoFeed Crash When Opened From Multiple Tabs With Slow Network #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scottkicks merged 2 commits into from
Aug 18, 2026
+8 −4
Merged

VideoFeed Crash When Opened From Multiple Tabs With Slow Network #2961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a20865
guard against VideoFeedViewController from being presented while alre…
scottkicks Aug 12, 2026
35ef92c
Clear loading state before guard
scottkicks Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...r-Framework/Kickstarter-iOS/Features/VideoFeed/Controller/VideoFeedBannerPresenting.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ extension VideoFeedBannerPresenting {
func presentVideoFeed(from cell: VideoFeedBannerCell) {
guard self.videoFeedVC == nil else {
/// Reuse an existing feed VC so VM state (optimistic saves, etc.) persists across opens.
if let existing = self.videoFeedVC, existing.isBeingPresented == false {
if let existing = self.videoFeedVC, existing.presentingViewController == nil,
!existing.isBeingPresented {
existing.modalPresentationStyle = .fullScreen
self.present(existing, animated: true)
}
Expand All @@ -26,12 +27,15 @@ extension VideoFeedBannerPresenting {
feedVC.loadViewIfNeeded()

feedVC.onReadyToPresent = { [weak self, weak cell, weak feedVC] in
guard let self, let feedVC else { return }

cell?.setLoading(false)

feedVC.modalPresentationStyle = .fullScreen
guard let self, let feedVC,
feedVC.presentingViewController == nil,
!feedVC.isBeingPresented else {
return
}

feedVC.modalPresentationStyle = .fullScreen
self.present(feedVC, animated: true)
}

Expand Down