VideoFeed Crash When Opened From Multiple Tabs With Slow Network

[scottkicks]

📲 What

Guard against a crash in VideoFeedBannerPresenting when VideoFeedViewController is presented twice in quick succession.

Crash Logs: Affecting a very minor amount of users, but might as well get ahead of it.

🤔 Why

On slow connections, a user could tap "Try it Now" on the Discovery tab, switch to Search while it's still loading, and tap "Try it Now" there too.
Both onReadyToPresent callbacks eventually fire and both attempt to present a VideoFeedViewController through RootTabBarViewController, which can throw an NSInvalidArgumentException and crashes.

🛠 How

In onReadyToPresent, added a guard that checks feedVC.presentingViewController == nil and !feedVC.isBeingPresented before calling present.
Also tightened the existing reuse path guard to use presentingViewController instead of only isBeingPresented, since isBeingPresented returns false once the presentation animation completes.

👀 See

No crash now 🪄

✅ Acceptance criteria

• Tap "Try it Now" on Discovery on a slow connection (Network Link Conditioner helps)
• While the banner is loading, switch to Search and tap "Try it Now"
• App should not crash — second tap is silently ignored
• Tapping "Try it Now" under normal conditions still opens the feed as expected

[stevestreza-ksr]

Makes sense to me. Maybe add an assertion failure there for debugging purposes if this happens, because if something makes this fail in development, it will fail silently.

[stevestreza-ksr]

You're calling cell?.setLoading(false) twice in the happy path, you could just move that above the guard.