Skip to content

Enable smooth CloudXR.js pacing #6865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hougantc-nvda wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −1
Open

Enable smooth CloudXR.js pacing #6865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/isaaclab_teleop/isaaclab_teleop/cloudxrjs-cloudxr.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
NV_DEVICE_PROFILE=auto-webrtc
NV_CXR_ENABLE_PUSH_DEVICES=0
NV_ENABLE_POSE_WAIT=0
NV_ENABLE_POSE_WAIT=1

@isaaclab-review-bot isaaclab-review-bot Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Warning · Implementation — Missing changelog fragment for isaaclab_teleop

Repository policy requires one changelog fragment per touched package under source/<pkg>/changelog.d/. This PR changes user-visible CloudXR.js runtime pacing behavior in isaaclab_teleop but adds no fragment, so the nightly changelog compilation and patch bump will omit it. Add source/isaaclab_teleop/changelog.d/<slug>.rst with a Fixed entry describing the pacing change; .skip is reserved for CI/docs/test-only changes.

NV_ENABLE_CONSERVATIVE_PACING=1
NV_SKIP_FRAME_ON_SPIKE=0
Comment on lines +3 to +5

@greptile-apps greptile-apps Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 CloudXR.js profile docs are stale

The profile now enables pose waiting and adds two pacing controls, but the existing configuration table and explanation still describe pose waiting as disabled for every profile. This leaves users with obsolete guidance when interpreting or troubleshooting the new pacing behavior.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Loading