Skip to content

Remove velocity play configs - #6860

Open
ClemensSchwarke wants to merge 4 commits into
isaac-sim:developfrom
ClemensSchwarke:fix/velocity-play-configs
Open

Remove velocity play configs#6860
ClemensSchwarke wants to merge 4 commits into
isaac-sim:developfrom
ClemensSchwarke:fix/velocity-play-configs

Conversation

@ClemensSchwarke

Copy link
Copy Markdown
Collaborator

Remove the reintroduced velocity environment play configs, as they are confusing and likely leftovers from previous experiments.

@ClemensSchwarke
ClemensSchwarke requested a review from a team August 3, 2026 08:44
@github-actions github-actions Bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Aug 3, 2026

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The PR removes robot-specific play_mode() overrides for Cassie, G1, and H1 rough-velocity configurations and deletes the test dedicated to those override values. The affected configurations now consistently use inherited play-mode behavior.

  • Design and architecture: The reviewed design decision centralizes play behavior in the shared base implementation instead of retaining per-robot command-range and episode-length customizations. This is coherent with the PR’s stated goal, with the explicit tradeoff that play runs no longer receive those robot-specific values.
  • API: The play_mode() entry point remains available through inheritance, so callers are not left without the method. The compatibility surface changes behavior rather than method availability: these configurations now receive the base play settings.
  • Implementation: The implementation consists of matched deletions: all three overrides are removed, and the regression test asserting their former values is removed with them. No contradictory producer or consumer path is evidenced by the supplied patch.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes robot-specific velocity playback overrides that were considered confusing experimental leftovers and deletes their obsolete regression test.

  • Cassie playback now inherits the shared velocity command configuration.
  • G1 and H1 playback now inherit shared command ranges and episode duration.
  • The test dedicated to the removed overrides is deleted.

Confidence Score: 5/5

The PR appears safe to merge because the configuration and test removals consistently implement the explicitly intended return to shared playback defaults.

The affected environments retain inherited playback setup while only the unwanted robot-specific command and duration overrides, along with their corresponding assertions, are removed.

Important Files Changed

Filename Overview
source/isaaclab_tasks/isaaclab_tasks/core/velocity/config/cassie/rough_env_cfg.py Removes Cassie-specific playback command ranges so playback uses the shared velocity configuration.
source/isaaclab_tasks/isaaclab_tasks/core/velocity/config/g1/rough_env_cfg.py Removes G1-specific playback duration and command overrides in favor of inherited behavior.
source/isaaclab_tasks/isaaclab_tasks/core/velocity/config/h1/rough_env_cfg.py Removes H1-specific playback duration and command overrides in favor of inherited behavior.
source/isaaclab_tasks/test/core/test_velocity_play_mode.py Deletes tests that asserted the intentionally removed robot-specific playback settings.

Reviews (1): Last reviewed commit: "remove play configs" | Re-trigger Greptile

@ooctipus

ooctipus commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

@ClemensSchwarke remember to update changelog fragment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants