prometheus: Safely detect Argo CD Application metrics - #1227
Open
Joshna907 wants to merge 1 commit into
Open
Conversation
Joshna907
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
August 20, 2026 10:18
Contributor
There was a problem hiding this comment.
Pull request overview
Adds strict Argo CD Application identification to Prometheus resource eligibility.
Changes:
- Allows Applications with exact
argoproj.io/v1alpha1. - Adds positive and negative unit coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
prometheus/src/util.ts |
Adds Application API-version validation and eligibility. |
prometheus/src/util.test.ts |
Tests Argo CD and same-kind non-Argo Applications. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Joshna907 <joshnawaikar@gmail.com>
Joshna907
force-pushed
the
codex/prometheus-argocd-metrics-guard
branch
from
August 25, 2026 09:19
cca871f to
aff56e0
Compare
Contributor
Author
|
Let's merge this @illume ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a safe Prometheus metrics eligibility check for Argo CD Applications.
This is the first half of Argo CD metrics support. It only recognizes the exact argoproj.io/v1alpha1 Application resource, so another Kubernetes resource with the same kind name cannot receive Argo CD metric charts by mistake.
Changes
Validation
Follow-up
The chart UI itself is deliberately in a separate follow-up PR, matching the earlier Volcano metrics work.