prometheus: Add Argo CD Application metric charts - #1228
Open
Joshna907 wants to merge 3 commits into
Open
Conversation
Joshna907
marked this pull request as ready for review
August 25, 2026 09:24
Joshna907
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
August 25, 2026 09:24
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional Prometheus charts to Argo CD Application details.
Changes:
- Adds sync activity, sync duration, and orphaned-resource charts.
- Restricts support to
argoproj.io/v1alpha1Applications. - Adds query escaping tests and documentation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
prometheus/src/util.ts |
Enables eligible Argo CD Applications. |
prometheus/src/util.test.ts |
Tests Application eligibility. |
prometheus/src/index.tsx |
Integrates charts into Application details. |
prometheus/src/components/Chart/ArgoCDApplicationChart/ArgoCDApplicationChart.tsx |
Defines charts and PromQL queries. |
prometheus/src/components/Chart/ArgoCDApplicationChart/ArgoCDApplicationChart.test.ts |
Tests chart configuration and escaping. |
prometheus/README.md |
Documents optional Application charts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Joshna907
force-pushed
the
codex/prometheus-argocd-application-charts
branch
from
August 25, 2026 11:08
d489de7 to
40a79d0
Compare
illume
requested changes
Aug 27, 2026
illume
left a comment
illume
left a comment
Contributor
There was a problem hiding this comment.
Has some git conflicts now, can you please take a look?
Signed-off-by: Joshna907 <joshnawaikar@gmail.com>
Signed-off-by: Joshna907 <joshnawaikar@gmail.com>
Signed-off-by: Joshna907 <joshnawaikar@gmail.com>
Joshna907
force-pushed
the
codex/prometheus-argocd-application-charts
branch
from
August 27, 2026 11:48
40a79d0 to
78f7e04
Compare
Contributor
Author
@illume ptal now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Prometheus charts to Argo CD Application details.
This PR follows the Volcano metrics UI pattern: chart selection, time range, resolution, pause/resume, and the normal no-data and error states.
Charts
Metrics are queried using the Application CR namespace and name. Prometheus remains optional: if it is disabled or Argo CD does not expose these metrics, the normal no-data state is shown.
Safety and scope
Validation
Dependency
Depends on #1227. Once it merges, this branch will be rebased so this PR contains only the chart changes.